Skip to content

Commit 0ba5261

Browse files
authored
Merge pull request #412 from myii/bug/fix-windows-py3
fix(windows): use correct `salt-minion` package name
2 parents b07e0cf + 1f0cefd commit 0ba5261

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

salt/osfamilymap.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
{% import_yaml "salt/ospyvermap.yaml" as ospyvermap %}
55
{% set ospyver = salt['grains.filter_by'](ospyvermap, grain='os_family') or {} %}
6-
{% set py_ver_dir = salt['pillar.filter_by'](ospyver, pillar='salt:py_ver', default='py2') %}
6+
{% set py_ver_repr = salt['pillar.filter_by'](ospyver, pillar='salt:py_ver', default='py2') %}
77

88
{% set osrelease = salt['grains.get']('osrelease') %}
99
{% set salt_release = salt['pillar.get']('salt:release', 'latest') %}
@@ -15,8 +15,8 @@
1515
{% set oscodename = salt['grains.get']('oscodename') %}
1616

1717
Debian:
18-
pkgrepo: 'deb http://repo.saltstack.com/{{ py_ver_dir }}/{{ osfamily_lower }}/{{ osmajorrelease }}/amd64/{{ salt_release }} {{ oscodename }} main'
19-
key_url: 'https://repo.saltstack.com/{{ py_ver_dir }}/{{ osfamily_lower }}/{{ osmajorrelease }}/amd64/{{ salt_release }}/SALTSTACK-GPG-KEY.pub'
18+
pkgrepo: 'deb http://repo.saltstack.com/{{ py_ver_repr }}/{{ osfamily_lower }}/{{ osmajorrelease }}/amd64/{{ salt_release }} {{ oscodename }} main'
19+
key_url: 'https://repo.saltstack.com/{{ py_ver_repr }}/{{ osfamily_lower }}/{{ osmajorrelease }}/amd64/{{ salt_release }}/SALTSTACK-GPG-KEY.pub'
2020
libgit2: libgit2-22
2121
pyinotify: python-pyinotify
2222
gitfs:
@@ -30,8 +30,8 @@ Debian:
3030
install_from_source: False
3131

3232
RedHat:
33-
pkgrepo: 'https://repo.saltstack.com/{{ py_ver_dir }}/redhat/$releasever/$basearch/{{ salt_release }}'
34-
key_url: 'https://repo.saltstack.com/{{ py_ver_dir }}/redhat/$releasever/$basearch/{{ salt_release }}/SALTSTACK-GPG-KEY.pub'
33+
pkgrepo: 'https://repo.saltstack.com/{{ py_ver_repr }}/redhat/$releasever/$basearch/{{ salt_release }}'
34+
key_url: 'https://repo.saltstack.com/{{ py_ver_repr }}/redhat/$releasever/$basearch/{{ salt_release }}/SALTSTACK-GPG-KEY.pub'
3535
pygit2: python-pygit2
3636
python_git: GitPython
3737
gitfs:
@@ -117,7 +117,7 @@ OpenBSD:
117117
python_git: py-GitPython
118118

119119
Windows:
120-
salt_minion: salt-minion
120+
salt_minion: salt-minion{{ py_ver_repr }}
121121
config_path: 'C:\salt\conf'
122122
minion_service: salt-minion
123123

salt/ospyvermap.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,13 @@ FreeBSD: {}
2121

2222
OpenBSD: {}
2323

24+
# This is *not* used directly with https://repo.saltstack.com
25+
# Rather, this is used with `salt-winrepo-ng`, where the package names are:
26+
# * py2: salt-minion
27+
# * py3: salt-minion-py3
2428
Windows:
25-
py2: 'Py2'
26-
py3: 'Py3'
29+
py2: ''
30+
py3: '-py3'
2731

2832
MacOS:
2933
py2: 'py2'

0 commit comments

Comments
 (0)