Properly handle subprocess.CalledProcessError

Fixes #21

Signed-off-by: Pedro Algarvio <[email protected]>

Author: s0undt3ch

changelog/21.bugfix.rst

@@ -0,0 +1 @@
+Properly handle `subprocess.CalledProcessError`. Catch the exception, print the error, and exit with the `.returncode` attribute value.

src/ptscripts/parser.py

@@ -9,6 +9,7 @@
 import logging
 import os
 import pathlib
+import subprocess
 import sys
 import typing
 from collections.abc import Iterator
@@ -178,14 +179,24 @@ def run(
         capture: bool = False,
         interactive: bool = False,
         **kwargs,
-    ) -> CompletedProcess[str]:
+    ) -> CompletedProcess[str] | None:
         """
         Run a subprocess.
 
         Either in a virtualenv context if one was configured or the system context.
         """
-        if self.venv:
-            return self.venv.run(
+        try:
+            if self.venv:
+                return self.venv.run(
+                    *cmdline,
+                    check=check,
+                    timeout_secs=timeout_secs,
+                    no_output_timeout_secs=no_output_timeout_secs,
+                    capture=capture,
+                    interactive=interactive,
+                    **kwargs,
+                )
+            return self._run(
                 *cmdline,
                 check=check,
                 timeout_secs=timeout_secs,
@@ -194,15 +205,10 @@ def run(
                 interactive=interactive,
                 **kwargs,
             )
-        return self._run(
-            *cmdline,
-            check=check,
-            timeout_secs=timeout_secs,
-            no_output_timeout_secs=no_output_timeout_secs,
-            capture=capture,
-            interactive=interactive,
-            **kwargs,
-        )
+        except subprocess.CalledProcessError as exc:
+            self.error(str(exc))
+            self.exit(exc.returncode)
+        return None
 
     @contextmanager
     def chdir(self, path: pathlib.Path) -> Iterator[pathlib.Path]: