Skip to content

Commit d0b69ba

Browse files
committed
Fix tests for XZ version on Windows
1 parent 84f3a8b commit d0b69ba

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

tests/test_build.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ def test_get_dependency_version_sqlite_all_platforms() -> None:
154154
def test_get_dependency_version_xz_all_platforms() -> None:
155155
"""Test getting XZ version for various platforms."""
156156
# XZ 5.5.0+ removed MSBuild support, so Windows uses a fallback version
157-
# and XZ is not in JSON for win32
158-
for platform in ["linux", "darwin"]:
157+
# BUT we now have XZ 5.8.2 in python-versions.json for win32 too
158+
for platform in ["linux", "darwin", "win32"]:
159159
result = get_dependency_version("xz", platform)
160160
assert result is not None, f"XZ should be available for {platform}"
161161
assert isinstance(result, dict)
@@ -166,10 +166,6 @@ def test_get_dependency_version_xz_all_platforms() -> None:
166166
assert "xz" in result["url"].lower()
167167
assert isinstance(result["sha256"], str)
168168

169-
# Windows should return None (uses hardcoded fallback in windows.py)
170-
result = get_dependency_version("xz", "win32")
171-
assert result is None, "XZ should not be in JSON for win32 (uses fallback)"
172-
173169

174170
def test_get_dependency_version_nonexistent() -> None:
175171
"""Test that nonexistent dependency returns None."""

0 commit comments

Comments
 (0)