Upgrade pre-commit hook versions

Signed-off-by: Pedro Algarvio <[email protected]>

Author: s0undt3ch

.pre-commit-config.yaml

@@ -53,7 +53,7 @@ repos:
   # <---- Local Hooks ------------------------------------------------------------------------------------------------
 
   - repo: https://github.com/s0undt3ch/python-tools-scripts
-    rev: "0.12.0"
+    rev: "0.17.0"
     hooks:
       - id: tools
         alias: actionlint
@@ -79,7 +79,7 @@ repos:
 
   # ----- Code Formatting and Analysis ---------------------------------------------------------->
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: "v0.0.265"
+    rev: "v0.0.277"
     hooks:
       - id: ruff
         args:
@@ -94,7 +94,7 @@ repos:
         exclude: src/saf/version.py
 
   - repo: https://github.com/asottile/blacken-docs
-    rev: 1.13.0
+    rev: 1.14.0
     hooks:
       - id: blacken-docs
         args: [--skip-errors]
@@ -103,7 +103,7 @@ repos:
           - black==23.3.0
 
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.2.0
+    rev: v1.4.1
     hooks:
       - id: mypy
         name: Run mypy against the code base

changelog/68.trivial.rst

@@ -2,3 +2,4 @@ Several trivial/internal updates to the project:
 
 * Allow the `nox -e build` target to also build the examples package
 * When updating `examples/requirements/all.txt` only care about `*.txt` files
+* Upgrade pre-commit hook versions

noxfile.py

@@ -235,7 +235,7 @@ def _tests(session, onedir=False, examples=False):
                 "xml",
                 "-o",
                 str(COVERAGE_REPORT_PROJECT),
-                f"--omit={str(tests_root / '*')}",
+                f"--omit={tests_root / '*'!s}",
                 "--include=src/saf/*",
             )
             # Generate report for tests code coverage
@@ -245,7 +245,7 @@ def _tests(session, onedir=False, examples=False):
                 "-o",
                 str(COVERAGE_REPORT_TESTS),
                 "--omit=src/saf/*",
-                f"--include={str(tests_root / '*')}",
+                f"--include={tests_root / '*'!s}",
             )
             try:
                 session.run("coverage", "report", "--show-missing", "--include=src/saf/*")

pyproject.toml

@@ -73,11 +73,14 @@ extend-include = [
 ]
 ignore = [
   # D* pydocstyle
-  "D200",   # Reformat to one line
-  "D212",   # Remove whitespace after opening quotes
-  "COM",    # flake8-commas - Black takes care of this
-  "ERA",    # eradicate
-  "SIM108", # Use ternary operator `A = X if Y else Z` instead of `if`-`else`-block
+  "D200",    # Reformat to one line
+  "D212",    # Remove whitespace after opening quotes
+  "COM",     # flake8-commas - Black takes care of this
+  "ERA",     # eradicate
+  "SIM108",  # Use ternary operator `A = X if Y else Z` instead of `if`-`else`-block
+  "PERF203", # `try`-`except` within a loop incurs performance overhead"
+  "PERF401", # Use a list comprehension to create a transformed list
+  "PERF402", # Use `list` or `list.copy` to create a copy of a list
 ]
 ignore-init-module-imports = true
 builtins = [
@@ -108,6 +111,9 @@ format = "grouped"
   "SLF001", # Private member accessed"
   "ARG003", # Unused class method argument: `kwargs`
 ]
+"src/saf/pipeline.py" = [
+  "PERF401",  # Use a list comprehension to create a transformed list"
+]
 "src/saf/collect/file.py" = [
   "TCH003",  # Move standard library import `pathlib` into a type-checking block
 ]
@@ -132,6 +138,7 @@ format = "grouped"
   "PLR0912",
   "DTZ005",
   "FBT002",
+  "PLR0913", # Too many arguments to function call"
   "PLR0915", # Too many statements
 ]
 "tools/**/*.py" = [

src/saf/collect/salt_exec.py

@@ -14,6 +14,7 @@
 from typing import Type
 
 import salt.loader
+from pydantic import Field
 
 from saf.models import CollectConfigBase
 from saf.models import CollectedEvent
@@ -29,8 +30,8 @@ class SaltExecConfig(CollectConfigBase):
 
     interval: float = 5
     fn: str = "test.ping"
-    args: List[Any] = []
-    kwargs: Dict[str, Any] = {}
+    args: List[Any] = Field(factory=list)
+    kwargs: Dict[str, Any] = Field(factory=dict)
 
 
 def get_config_schema() -> Type[SaltExecConfig]:

src/saf/process/jupyter_notebook.py

@@ -14,6 +14,8 @@
 from typing import Optional
 from typing import Type
 
+from pydantic import Field
+
 from saf.models import CollectedEvent
 from saf.models import PipelineRunContext
 from saf.models import ProcessConfigBase
@@ -28,8 +30,8 @@ class JupyterNotebookConfig(ProcessConfigBase):
 
     notebook: pathlib.Path
     output_notebook: Optional[pathlib.Path]
-    params: Dict[str, Any] = {}
-    papermill_kwargs: Dict[str, Any] = {}
+    params: Dict[str, Any] = Field(factory=dict)
+    papermill_kwargs: Dict[str, Any] = Field(factory=dict)
     output_tag: Optional[str]
     input_keys: List[str]