Make systemctl/hostctl check functions check they're on linux

Author: barneysowood

tests/integration/modules/test_localemod.py

@@ -2,13 +2,17 @@
 
 import pytest
 
+import salt.utils.platform
 from tests.support.case import ModuleCase
 
 
 def _check_systemctl():
     if not hasattr(_check_systemctl, "memo"):
-        proc = subprocess.run(["localectl"], capture_output=True, check=False)
-        _check_systemctl.memo = b"No such file or directory" in proc.stderr
+        if not salt.utils.platform.is_linux():
+            _check_systemctl.memo = False
+        else:
+            proc = subprocess.run(["localectl"], capture_output=True, check=False)
+            _check_systemctl.memo = b"No such file or directory" in proc.stderr
     return _check_systemctl.memo
 
 

tests/integration/modules/test_timezone.py

@@ -8,6 +8,7 @@
 
 import pytest
 
+import salt.utils.platform
 from tests.support.case import ModuleCase
 
 try:
@@ -20,8 +21,11 @@
 
 def _check_systemctl():
     if not hasattr(_check_systemctl, "memo"):
-        proc = subprocess.run(["timedatectl"], capture_output=True, check=False)
-        _check_systemctl.memo = b"No such file or directory" in proc.stderr
+        if not salt.utils.platform.is_linux():
+            _check_systemctl.memo = False
+        else:
+            proc = subprocess.run(["timedatectl"], capture_output=True, check=False)
+            _check_systemctl.memo = b"No such file or directory" in proc.stderr
     return _check_systemctl.memo
 
 

tests/pytests/functional/modules/test_service.py

@@ -17,10 +17,14 @@
 
 def _check_systemctl():
     if not hasattr(_check_systemctl, "memo"):
-        proc = subprocess.run(["systemctl"], capture_output=True, check=False)
-        _check_systemctl.memo = (
-            b"Failed to get D-Bus connection: No such file or directory" in proc.stderr
-        )
+        if not salt.utils.platform.is_linux():
+            _check_systemctl.memo = False
+        else:
+            proc = subprocess.run(["systemctl"], capture_output=True, check=False)
+            _check_systemctl.memo = (
+                b"Failed to get D-Bus connection: No such file or directory"
+                in proc.stderr
+            )
     return _check_systemctl.memo
 
 

tests/pytests/functional/modules/test_system.py

@@ -22,12 +22,15 @@
 
 def check_hostnamectl():
     if not hasattr(check_hostnamectl, "memo"):
-        proc = subprocess.run(["hostnamectl"], capture_output=True, check=False)
-        check_hostnamectl.memo = (
-            b"Failed to connect to bus: No such file or directory" in proc.stderr
-            or b"Failed to create bus connection: No such file or directory"
-            in proc.stderr
-        )
+        if not salt.utils.platform.is_linux():
+            check_hostnamectl.memo = False
+        else:
+            proc = subprocess.run(["hostnamectl"], capture_output=True, check=False)
+            check_hostnamectl.memo = (
+                b"Failed to connect to bus: No such file or directory" in proc.stderr
+                or b"Failed to create bus connection: No such file or directory"
+                in proc.stderr
+            )
     return check_hostnamectl.memo
 
 

tests/pytests/functional/states/test_service.py

@@ -24,11 +24,15 @@
 
 def _check_systemctl():
     if not hasattr(_check_systemctl, "memo"):
-        proc = subprocess.run(["systemctl"], capture_output=True, check=False)
-        _check_systemctl.memo = (
-            b"Failed to get D-Bus connection: No such file or directory" in proc.stderr
-            or b"Failed to connect to bus: No such file or directory" in proc.stderr
-        )
+        if not salt.utils.platform.is_linux():
+            _check_systemctl.memo = False
+        else:
+            proc = subprocess.run(["systemctl"], capture_output=True, check=False)
+            _check_systemctl.memo = (
+                b"Failed to get D-Bus connection: No such file or directory"
+                in proc.stderr
+                or b"Failed to connect to bus: No such file or directory" in proc.stderr
+            )
     return _check_systemctl.memo
 
 

tests/pytests/unit/states/test_service.py

@@ -19,11 +19,15 @@
 
 def _check_systemctl():
     if not hasattr(_check_systemctl, "memo"):
-        proc = subprocess.run(["systemctl"], capture_output=True, check=False)
-        _check_systemctl.memo = (
-            b"Failed to get D-Bus connection: No such file or directory" in proc.stderr
-            or b"Failed to connect to bus: No such file or directory" in proc.stderr
-        )
+        if not salt.utils.platform.is_linux():
+            _check_systemctl.memo = False
+        else:
+            proc = subprocess.run(["systemctl"], capture_output=True, check=False)
+            _check_systemctl.memo = (
+                b"Failed to get D-Bus connection: No such file or directory"
+                in proc.stderr
+                or b"Failed to connect to bus: No such file or directory" in proc.stderr
+            )
     return _check_systemctl.memo