gdrive: enforce at least one path mapping

Author: saltydk

internal/web/handlers/triggers.go

@@ -239,6 +239,10 @@ func (h *Handlers) TriggerCreate(w http.ResponseWriter, r *http.Request) {
 
 		mappingIDs := r.Form["gdrive_path_rewrite_from_id[]"]
 		mappingTargets := r.Form["gdrive_path_rewrite_to[]"]
+		if !hasGDrivePathMapping(mappingIDs, mappingTargets) {
+			respondError(http.StatusBadRequest, "At least one Google Drive path mapping is required")
+			return
+		}
 		mappings, err := h.resolveGDrivePathMappings(r.Context(), accountID, driveID, mappingIDs, mappingTargets)
 		if err != nil {
 			respondError(http.StatusBadRequest, "Invalid Google Drive path mapping: "+err.Error())
@@ -562,6 +566,10 @@ func (h *Handlers) TriggerUpdate(w http.ResponseWriter, r *http.Request) {
 
 		mappingIDs := r.Form["gdrive_path_rewrite_from_id[]"]
 		mappingTargets := r.Form["gdrive_path_rewrite_to[]"]
+		if !hasGDrivePathMapping(mappingIDs, mappingTargets) {
+			respondError(http.StatusBadRequest, "At least one Google Drive path mapping is required", "/triggers/"+idStr)
+			return
+		}
 		mappings, err := h.resolveGDrivePathMappings(r.Context(), accountID, driveID, mappingIDs, mappingTargets)
 		if err != nil {
 			respondError(http.StatusBadRequest, "Invalid Google Drive path mapping: "+err.Error(), "/triggers/"+idStr)
@@ -827,6 +835,21 @@ func parsePathList(r *http.Request, fieldName string) []string {
 	return paths
 }
 
+func hasGDrivePathMapping(fromIDs, toPaths []string) bool {
+	max := len(fromIDs)
+	if len(toPaths) < max {
+		max = len(toPaths)
+	}
+	for i := 0; i < max; i++ {
+		fromID := strings.TrimSpace(fromIDs[i])
+		toPath := strings.TrimSpace(toPaths[i])
+		if fromID != "" && toPath != "" {
+			return true
+		}
+	}
+	return false
+}
+
 func boolPtr(value bool) *bool {
 	return &value
 }

internal/web/templates/triggers.html

@@ -166,7 +166,7 @@ <h1 class="text-2xl font-semibold text-gray-900 dark:text-white">New Trigger</h1
                 </select>
                 <p class="mt-1 text-xs text-gray-500 dark:text-gray-400">Choose My Drive or a shared drive for this trigger.</p>
             </div>
-            <p class="text-xs text-gray-500 dark:text-gray-400">This trigger always monitors the full drive. Use Include Paths below to scope what gets processed.</p>
+            <p class="text-xs text-gray-500 dark:text-gray-400">This trigger always monitors the full drive. Add at least one path mapping below to process files.</p>
         </div>
 
         <div id="gdrive-mapping-modal" class="fixed inset-0 z-50 hidden items-center justify-center bg-gray-900/60 px-4">
@@ -239,7 +239,7 @@ <h4 class="text-sm font-medium text-gray-900 dark:text-white">Authentication</h4
             <div class="flex items-center justify-between mb-2">
                 <div>
                     <label class="block text-sm font-medium text-gray-700 dark:text-gray-300">Path Mapping (Google Drive)</label>
-                    <p class="text-xs text-gray-500 dark:text-gray-400 mt-1">Map a Drive folder to a local path using the folder picker.</p>
+                    <p class="text-xs text-gray-500 dark:text-gray-400 mt-1">Map a Drive folder to a local path using the folder picker. At least one mapping is required.</p>
                 </div>
                 <button type="button" id="gdrive-add-path-rewrite" class="btn-secondary text-xs">
                     Add Mapping
@@ -581,6 +581,37 @@ <h4 class="text-sm font-medium text-gray-900 dark:text-white mb-4">File Stabilit
         return true;
     }
 
+    function validateGDriveMappings() {
+        const typeSelect = document.getElementById('type');
+        if (!typeSelect || typeSelect.value !== 'gdrive') {
+            return true;
+        }
+        const list = document.getElementById('gdrive-path-rewrites-list');
+        if (!list) {
+            return true;
+        }
+        const rows = list.querySelectorAll('[data-role="gdrive-map-row"]');
+        let hasMapping = false;
+
+        rows.forEach((row) => {
+            const fromInput = row.querySelector('[data-role="gdrive-map-from-id"]');
+            const toInput = row.querySelector('[data-role="gdrive-map-to"]');
+            if (!fromInput || !toInput) {
+                return;
+            }
+            if (fromInput.value.trim() !== '' && toInput.value.trim() !== '') {
+                hasMapping = true;
+            }
+        });
+
+        if (!hasMapping) {
+            showAlertModal('error', 'Missing Path Mapping', 'Add at least one Google Drive path mapping.');
+            return false;
+        }
+
+        return true;
+    }
+
     function handleTriggerFormSubmit(event, listId) {
         if (event) {
             event.preventDefault();
@@ -595,6 +626,9 @@ <h4 class="text-sm font-medium text-gray-900 dark:text-white mb-4">File Stabilit
         if (listId && !validatePathRewrites(listId)) {
             return false;
         }
+        if (!validateGDriveMappings()) {
+            return false;
+        }
         if (!form.checkValidity()) {
             form.reportValidity();
             return false;
@@ -1069,7 +1103,7 @@ <h3 class="text-lg font-medium text-gray-900 dark:text-white mb-4">Change Trigge
             <div class="flex items-center justify-between mb-2">
                 <div>
                     <label class="block text-sm font-medium text-gray-700 dark:text-gray-300">Path Mapping (Google Drive)</label>
-                    <p class="text-xs text-gray-500 dark:text-gray-400 mt-1">Map a Drive folder to a local path using the folder picker.</p>
+                    <p class="text-xs text-gray-500 dark:text-gray-400 mt-1">Map a Drive folder to a local path using the folder picker. At least one mapping is required.</p>
                 </div>
                 <button type="button" id="gdrive-add-path-rewrite" class="btn-secondary text-xs">
                     Add Mapping
@@ -1154,6 +1188,33 @@ <h3 class="text-lg font-medium text-gray-900 dark:text-white mb-4">Change Trigge
             return true;
         }
 
+        function validateGDriveMappings() {
+            const list = document.getElementById('gdrive-path-rewrites-list');
+            if (!list) {
+                return true;
+            }
+            const rows = list.querySelectorAll('[data-role="gdrive-map-row"]');
+            let hasMapping = false;
+
+            rows.forEach((row) => {
+                const fromInput = row.querySelector('[data-role="gdrive-map-from-id"]');
+                const toInput = row.querySelector('[data-role="gdrive-map-to"]');
+                if (!fromInput || !toInput) {
+                    return;
+                }
+                if (fromInput.value.trim() !== '' && toInput.value.trim() !== '') {
+                    hasMapping = true;
+                }
+            });
+
+            if (!hasMapping) {
+                showAlertModal('error', 'Missing Path Mapping', 'Add at least one Google Drive path mapping.');
+                return false;
+            }
+
+            return true;
+        }
+
         function handleTriggerFormSubmit(event) {
             if (event) {
                 event.preventDefault();
@@ -1168,6 +1229,9 @@ <h3 class="text-lg font-medium text-gray-900 dark:text-white mb-4">Change Trigge
             if (!validateEditPathRewrites()) {
                 return false;
             }
+            if (!validateGDriveMappings()) {
+                return false;
+            }
             if (!form.checkValidity()) {
                 form.reportValidity();
                 return false;