Skip to content

Commit 0374a29

Browse files
committed
build.rpms: Add support for custom vendor dist suffix
Like %{dist}, 'vendor_dist_suffix' environment variable is supposed to contain the required delimiter i.e, dot('.') to get it meaningfully added to the 'Release' tag.
1 parent f96eff6 commit 0374a29

File tree

11 files changed

+15
-7
lines changed

11 files changed

+15
-7
lines changed

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ ifneq ($(ceph_repo_gpgkey),)
2121
EXTRA_VARS += ceph_repo_gpgkey=$(ceph_repo_gpgkey)
2222
endif
2323

24+
ifneq ($(vendor_dist_suffix),)
25+
EXTRA_VARS += vendor_dist_suffix=$(vendor_dist_suffix)
26+
endif
27+
2428
prep.dirs:
2529
@ansible-playbook --inventory localhost, ./ansible/prep.dirs.yml
2630

ansible/build.rpms.centos.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
refspec: "{{ refspec }}"
66
os_vers: "{{ version | default('9') }}"
77
os_arch: "{{ arch | default('x86_64') }}"
8+
vendor_dist: "{{ vendor_dist_suffix | default('%{nil}') }}"
89
vars_files:
910
- vars.yml
1011
roles:

ansible/build.rpms.fedora.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
refspec: "{{ refspec }}"
66
os_vers: "{{ version | default('42') }}"
77
os_arch: "{{ arch | default('x86_64') }}"
8+
vendor_dist: "{{ vendor_dist_suffix | default('%{nil}') }}"
89
vars_files:
910
- vars.yml
1011
roles:

ansible/build.rpms.rhel.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
os_arch: "{{ arch | default('x86_64') }}"
88
org_id: "{{ lookup('env', 'ORG_ID', default=Undefined) }}"
99
act_key: "{{ lookup('env', 'ACT_KEY', default=Undefined) }}"
10+
vendor_dist: "{{ vendor_dist_suffix | default('%{nil}') }}"
1011
vars_files:
1112
- vars.yml
1213
roles:
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
- name: build centos {{ os_vers }} rpms
2-
command: /usr/bin/mock --root {{ mock_dir }}/centos-stream+epel-next-{{ os_vers }}-{{ os_arch }}.cfg --resultdir {{ rpms_dir }}/{{ samba_major_version }}/centos/{{ os_vers }}/{{ os_arch }} --rebuild {{ srpm_dir }}/{{ samba_srpm }}
2+
command: /usr/bin/mock --root {{ mock_dir }}/centos-stream+epel-next-{{ os_vers }}-{{ os_arch }}.cfg --resultdir {{ rpms_dir }}/{{ samba_major_version }}/centos/{{ os_vers }}/{{ os_arch }} --define "vendor_dist {{ vendor_dist }}" --rebuild {{ srpm_dir }}/{{ samba_srpm }}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
- name: build fedora {{ os_vers }} rpms
2-
command: /usr/bin/mock --root {{ mock_dir }}/fedora-{{ os_vers }}-{{ os_arch }}.cfg --resultdir {{ rpms_dir }}/{{ samba_major_version }}/fedora/{{ os_vers }}/{{ os_arch }} --rebuild {{ srpm_dir }}/{{ samba_srpm }}
2+
command: /usr/bin/mock --root {{ mock_dir }}/fedora-{{ os_vers }}-{{ os_arch }}.cfg --resultdir {{ rpms_dir }}/{{ samba_major_version }}/fedora/{{ os_vers }}/{{ os_arch }} --define "vendor_dist {{ vendor_dist }}" --rebuild {{ srpm_dir }}/{{ samba_srpm }}

ansible/roles/build.rpms.rhel/files/rpm-build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ dnf -y install https://dl.fedoraproject.org/pub/epel/epel-release-latest-${OS_VE
88

99
dnf -y install mock rpm-build
1010

11-
mock --root "${MOCK_DIR}/rhel-${OS_VERS}-${OS_ARCH}.cfg" --resultdir "${RPMS_DIR}/${SAMBA_VERS}/rhel/${OS_VERS}/${OS_ARCH}" --rebuild "${SRPM_DIR}/${SAMBA_SRPM}"
11+
mock --root "${MOCK_DIR}/rhel-${OS_VERS}-${OS_ARCH}.cfg" --resultdir "${RPMS_DIR}/${SAMBA_VERS}/rhel/${OS_VERS}/${OS_ARCH}" --define "vendor_dist ${VENDOR_DIST}" --rebuild "${SRPM_DIR}/${SAMBA_SRPM}"
1212

1313
subscription-manager unregister

ansible/roles/build.rpms.rhel/tasks/main.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
- name: Build rhel {{ os_vers }} rpms locally
33
when: org_id is undefined or act_key is undefined
4-
command: /usr/bin/mock --root {{ mock_dir }}/rhel-{{ os_vers }}-{{ os_arch }}.cfg --resultdir {{ rpms_dir }}/{{ samba_major_version }}/rhel/{{ os_vers }}/{{ os_arch }} --rebuild {{ srpm_dir }}/{{ samba_srpm }}
4+
command: /usr/bin/mock --root {{ mock_dir }}/rhel-{{ os_vers }}-{{ os_arch }}.cfg --resultdir {{ rpms_dir }}/{{ samba_major_version }}/rhel/{{ os_vers }}/{{ os_arch }} --define "vendor_dist {{ vendor_dist }}" --rebuild {{ srpm_dir }}/{{ samba_srpm }}
55

66
- name: Build rhel {{ os_vers }} rpms in a container
77
when: org_id is defined and act_key is defined
@@ -25,3 +25,4 @@
2525
RPMS_DIR: "{{ rpms_dir }}"
2626
SAMBA_SRPM: "{{ samba_srpm }}"
2727
SAMBA_VERS: "{{ samba_major_version }}"
28+
VENDOR_DIST: "{{ vendor_dist }}"

packaging/samba-4.21.spec.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@
112112

113113
Name: samba
114114
Version: %{samba_version}
115-
Release: %{samba_release}%{?dist}
115+
Release: %{samba_release}%{?dist}%{?vendor_dist}
116116

117117
%if 0%{?rhel}
118118
Epoch: 0

packaging/samba-4.22.spec.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@
112112

113113
Name: samba
114114
Version: %{samba_version}
115-
Release: %{samba_release}%{?dist}
115+
Release: %{samba_release}%{?dist}%{?vendor_dist}
116116

117117
%if 0%{?rhel}
118118
Epoch: 0

0 commit comments

Comments
 (0)