rpmspec: Remove unwanted requires for external libldb

We always build with internal libldb. Thus we never used to depend
on system installed/external libldb all this while. But somehow this
special requires still existed. We haven't had a problem because libldb
versions were much lower than samba versions until upstream decided to
ship libldb with a matching samba version as a private or public library
with 4.21. Now various libldb .so files from standard repositories(same
version as samba) conflicts with the exact same content that we bundle
during our build process.

Therefore we remove this left over as we never depend on externally
installed libldb in our samba builds. These were also removed from
upstream packaging sources.

ref: https://www.samba.org/samba/history/samba-4.21.0.html
ref: https://src.fedoraproject.org/rpms/samba/c/d0472882
ref: https://src.fedoraproject.org/rpms/samba/pull-request/39

Author: anoopcs9

packaging/samba-4.20.spec.j2

@@ -71,8 +71,6 @@
 %bcond_with etcd_mutex
 %endif
 
-%define samba_requires_eq()  %(LC_ALL="C" echo '%*' | xargs -r rpm -q --qf 'Requires: %%{name} = %%{epoch}:%%{version}\\n' | sed -e 's/ (none):/ /' -e 's/ 0:/ /' | grep -v "is not")
-
 %global baserelease 1
 
 %global samba_version {{ samba_rpm_version }}
@@ -504,11 +502,6 @@ Requires: libwbclient = %{samba_depver}
 %endif
 Requires: ldb-tools
 Requires: python3-setproctitle
-# Force using libldb version to be the same as build version
-# Otherwise LDB modules will not be loaded and samba-tool will fail
-# See bug 1507420
-%samba_requires_eq libldb
-
 Requires: python3-%{name} = %{samba_depver}
 Requires: python3-%{name}-dc = %{samba_depver}
 Requires: krb5-server >= %{required_mit_krb5}

packaging/samba-4.21.spec.j2

@@ -71,8 +71,6 @@
 %bcond_with etcd_mutex
 %endif
 
-%define samba_requires_eq()  %(LC_ALL="C" echo '%*' | xargs -r rpm -q --qf 'Requires: %%{name} = %%{epoch}:%%{version}\\n' | sed -e 's/ (none):/ /' -e 's/ 0:/ /' | grep -v "is not")
-
 %global baserelease 1
 
 %global samba_version {{ samba_rpm_version }}
@@ -502,11 +500,6 @@ Requires: libwbclient = %{samba_depver}
 %endif
 Requires: ldb-tools
 Requires: python3-setproctitle
-# Force using libldb version to be the same as build version
-# Otherwise LDB modules will not be loaded and samba-tool will fail
-# See bug 1507420
-%samba_requires_eq libldb
-
 Requires: python3-%{name} = %{samba_depver}
 Requires: python3-%{name}-dc = %{samba_depver}
 Requires: krb5-server >= %{required_mit_krb5}

packaging/samba-master.spec.j2

@@ -71,8 +71,6 @@
 %bcond_with etcd_mutex
 %endif
 
-%define samba_requires_eq()  %(LC_ALL="C" echo '%*' | xargs -r rpm -q --qf 'Requires: %%{name} = %%{epoch}:%%{version}\\n' | sed -e 's/ (none):/ /' -e 's/ 0:/ /' | grep -v "is not")
-
 %global baserelease 1
 
 %global samba_version {{ samba_rpm_version }}
@@ -502,11 +500,6 @@ Requires: libwbclient = %{samba_depver}
 %endif
 Requires: ldb-tools
 Requires: python3-setproctitle
-# Force using libldb version to be the same as build version
-# Otherwise LDB modules will not be loaded and samba-tool will fail
-# See bug 1507420
-%samba_requires_eq libldb
-
 Requires: python3-%{name} = %{samba_depver}
 Requires: python3-%{name}-dc = %{samba_depver}
 Requires: krb5-server >= %{required_mit_krb5}