Skip to content

Commit 49ea1cd

Browse files
phlogistonjohnobnoxxx
authored andcommitted
server: split steps installing packages and sambacc
By splitting the build this way the layer containing the system packages and that containing sambacc install can be independently cached. The (probably) less frequently changing packages layer may be reused more often than the more frequently changing (for now) sambacc layer. Signed-off-by: John Mulligan <[email protected]>
1 parent b4d9c72 commit 49ea1cd

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

images/server/Dockerfile.fedora

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ MAINTAINER John Mulligan <[email protected]>
1313
ENV SAMBACC_VERSION="0.1"
1414

1515
COPY smb.conf /etc/samba/smb.conf
16-
COPY --from=builder \
17-
/var/tmp/build/sambacc/dist/sambacc-$SAMBACC_VERSION-py3-none-any.whl \
18-
/tmp/sambacc-$SAMBACC_VERSION-py3-none-any.whl
1916
RUN dnf install -y \
2017
findutils \
2118
python-pip \
@@ -26,10 +23,15 @@ RUN dnf install -y \
2623
samba-winbind \
2724
samba-winbind-clients \
2825
tdb-tools \
29-
&& pip install /tmp/sambacc-$SAMBACC_VERSION-py3-none-any.whl \
26+
&& dnf clean all \
27+
&& true
28+
29+
COPY --from=builder \
30+
/var/tmp/build/sambacc/dist/sambacc-$SAMBACC_VERSION-py3-none-any.whl \
31+
/tmp/sambacc-$SAMBACC_VERSION-py3-none-any.whl
32+
RUN pip install /tmp/sambacc-$SAMBACC_VERSION-py3-none-any.whl \
3033
&& rm -f /tmp/sambacc-$SAMBACC_VERSION-py3-none-any.whl \
3134
&& ln -s /usr/local/share/sambacc/examples/minimal.json /etc/samba/container.json \
32-
&& yum clean all \
3335
&& true
3436

3537

0 commit comments

Comments
 (0)