tests: fix various quoting issues found by shellcheck

Signed-off-by: John Mulligan <[email protected]>

Author: phlogistonjohn

tests/test-deploy-ad-member.sh

@@ -28,12 +28,12 @@ until [ $tries -ge 120 ] || echo $podstatus | grep -q 'Running'; do
 	sleep 1
 	echo -n "."
 	tries=$(( tries + 1 ))
-	podstatus="$(kubectl get pod $podname -o go-template='{{.status.phase}}')"
+	podstatus="$(kubectl get pod "$podname" -o go-template='{{.status.phase}}')"
 done
 echo
 kubectl get pod
 echo
-echo $podstatus | grep -q 'Running' || _error "Pod did not reach Running state"
+echo "$podstatus" | grep -q 'Running' || _error "Pod did not reach Running state"
 
 echo "waiting for samba to become reachable"
 tries=0

tests/test-deploy-ad-server.sh

@@ -16,10 +16,10 @@ fi
 
 kubectl get deployment
 
-replicaset="$(kubectl describe deployment ${AD_DEPLOYMENT_NAME} | grep -s "NewReplicaSet:" | awk '{ print $2 }')"
+replicaset="$(kubectl describe deployment "${AD_DEPLOYMENT_NAME}" | grep -s "NewReplicaSet:" | awk '{ print $2 }')"
 [ $? -eq 0 ] || _error "Error getting replicaset"
 
-podname="$(kubectl get pod | grep $replicaset | awk '{ print $1 }')"
+podname="$(kubectl get pod | grep "$replicaset" | awk '{ print $1 }')"
 [ $? -eq 0 ] || _error "Error getting podname"
 
 echo "Samba ad pod is $podname"
@@ -31,12 +31,12 @@ until [ $tries -ge 120 ] || echo $podstatus | grep -q 'Running'; do
 	sleep 1
 	echo -n "."
 	tries=$(( tries + 1 ))
-	podstatus="$(kubectl get pod $podname -o go-template='{{.status.phase}}')"
+	podstatus="$(kubectl get pod "$podname" -o go-template='{{.status.phase}}')"
 done
 echo
 kubectl get pod
 echo
-echo $podstatus | grep -q 'Running' || _error "Pod did not reach Running state"
+echo "$podstatus" | grep -q 'Running' || _error "Pod did not reach Running state"
 
 echo "waiting for samba to become reachable"
 tries=0
@@ -76,15 +76,15 @@ echo >> "${TMPFILE}"
 FIRSTLINE="$(head -1 ./tests/files/coredns-snippet.template)"
 LASTLINE="    }"
 
-sed -i .backup -e "/$FIRSTLINE/,/$LASTLINE/d" ${TMPFILE}
+sed -i .backup -e "/$FIRSTLINE/,/$LASTLINE/d" "${TMPFILE}"
 
-cat tests/files/coredns-snippet.template \
-	| sed -e "s/AD_SERVER_IP/${AD_POD_IP}/" \
+sed -e "s/AD_SERVER_IP/${AD_POD_IP}/" \
+	< tests/files/coredns-snippet.template \
 	>> "${TMPFILE}"
 
 echo >> "${TMPFILE}"
 
-kubectl patch cm -n kube-system coredns -p "$(cat ${TMPFILE})"
+kubectl patch cm -n kube-system coredns -p "$(cat "${TMPFILE}")"
 [ $? -eq 0 ] || _error "Error patching coredns config map"
 
 echo "ad setup done"

tests/test-remove-ad-member.sh

@@ -4,7 +4,7 @@ SCRIPT_DIR="$(cd "$(dirname "${0}")" && pwd)"
 
 source "${SCRIPT_DIR}/common.sh"
 
-if [ ${KEEP} -eq 1 ]; then
+if [ "${KEEP}" -eq 1 ]; then
 	echo "keeping ad member pod (KEEP=1)"
 	exit 0
 fi

tests/test-remove-ad-server.sh

@@ -4,7 +4,7 @@ SCRIPT_DIR="$(cd "$(dirname "${0}")" && pwd)"
 
 source "${SCRIPT_DIR}/common.sh"
 
-if [ ${KEEP} -eq 1 ]; then
+if [ "${KEEP}" -eq 1 ]; then
 	echo "keeping ad server deployment (KEEP=1)"
 	exit 0
 fi

tests/test-samba-ad-server-kubernetes.sh

@@ -4,23 +4,23 @@ SCRIPT_DIR="$(cd "$(dirname "${0}")" && pwd)"
 
 source "${SCRIPT_DIR}/common.sh"
 
-source ${SCRIPT_DIR}/test-deploy-ad-server.sh
+source "${SCRIPT_DIR}/test-deploy-ad-server.sh"
 
 kubectl exec "${podname}" -- samba-tool domain info 127.0.0.1
 [ $? -eq 0 ] || _error "Error listing domain info"
 echo
 
-source ${SCRIPT_DIR}/test-deploy-ad-member.sh
+source "${SCRIPT_DIR}/test-deploy-ad-member.sh"
 
 kubectl exec "${podname}" -c "smb" -- smbclient -N -L 127.0.0.1
 kubectl exec "${podname}" -c "winbind" -- wbinfo -t
 # note: testing `wbinfo -t` from the smb container again
 # to make sure samba can communicate to winbindd
 kubectl exec "${podname}" -c "smb" -- wbinfo -t
 
-source ${SCRIPT_DIR}/test-remove-ad-member.sh
+source "${SCRIPT_DIR}/test-remove-ad-member.sh"
 
-source ${SCRIPT_DIR}/test-remove-ad-server.sh
+source "${SCRIPT_DIR}/test-remove-ad-server.sh"
 
 echo
 echo "Success"