Skip to content

Commit fa13deb

Browse files
makefile: add phony lines to various build-* rules
These rules were always "symbolic" names and probably should have been marked as PHONY all along. Signed-off-by: John Mulligan <[email protected]>
1 parent f2b9ed9 commit fa13deb

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,15 @@ build: build-server build-nightly-server build-ad-server build-client
5151
.PHONY: build
5252

5353
build-server: $(BUILDFILE_SERVER)
54+
.PHONY: build-server
5455
$(BUILDFILE_SERVER): Makefile $(SERVER_SRC_FILE) $(SERVER_SOURCES)
5556
$(BUILD_CMD) \
5657
--tag $(SERVER_NAME) --tag $(SERVER_REPO_NAME) \
5758
-f $(SERVER_SRC_FILE) $(SERVER_DIR)
5859
$(CONTAINER_CMD) inspect -f '{{.Id}}' $(SERVER_NAME) > $(BUILDFILE_SERVER)
5960

6061
build-nightly-server: $(BUILDFILE_NIGHTLY_SERVER)
62+
.PHONY: build-nightly-server
6163
$(BUILDFILE_NIGHTLY_SERVER): Makefile $(SERVER_SRC_FILE) $(SERVER_SOURCES)
6264
$(BUILD_CMD) \
6365
--build-arg=INSTALL_PACKAGES_FROM="samba-nightly" \
@@ -75,6 +77,7 @@ push-nightly-server: build-nightly-server
7577
.PHONY: push-nightly-server
7678

7779
build-ad-server: $(BUILDFILE_AD_SERVER)
80+
.PHONY: build-ad-server
7881
$(BUILDFILE_AD_SERVER): Makefile $(AD_SERVER_SRC_FILE) $(AD_SERVER_SOURCES)
7982
$(BUILD_CMD) --tag $(AD_SERVER_NAME) --tag $(AD_SERVER_REPO_NAME) -f $(AD_SERVER_SRC_FILE) $(AD_SERVER_DIR)
8083
$(CONTAINER_CMD) inspect -f '{{.Id}}' $(AD_SERVER_NAME) > $(BUILDFILE_AD_SERVER)
@@ -84,6 +87,7 @@ push-ad-server: build-ad-server
8487
.PHONY: push-ad-server
8588

8689
build-client: $(BUILDFILE_CLIENT)
90+
.PHONY: build-client
8791
$(BUILDFILE_CLIENT): Makefile $(CLIENT_SRC_FILE)
8892
$(BUILD_CMD) --tag $(CLIENT_NAME) --tag $(CLIENT_REPO_NAME) -f $(CLIENT_SRC_FILE) $(CLIENT_DIR)
8993
$(CONTAINER_CMD) inspect -f '{{.Id}}' $(CLIENT_NAME) > $(BUILDFILE_CLIENT)

0 commit comments

Comments
 (0)