Skip to content

Commit 0903dbf

Browse files
synaretephlogistonjohn
authored andcommitted
tests: require pod-ready before testing metrics
Even when metrics is disabled, we need a ready pod in order to check the samba-metrics container. Expects samba pod to be ready before poking into the pod's state. Without this check the test would fail, but with an enigmatic error message. Signed-off-by: Shachar Sharon <[email protected]>
1 parent d9ed4ca commit 0903dbf

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

tests/integration/smb_share_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,8 @@ func (s *SmbShareWithExternalNetSuite) TestServiceIsLoadBalancer() {
284284
}
285285

286286
func (s *SmbShareSuite) TestMetricsOnPod() {
287+
s.Require().NoError(waitForPodReady(s))
288+
287289
pod, cont, err := s.getMetricsContainer()
288290
s.Require().NoError(err)
289291
if cont == nil {

0 commit comments

Comments
 (0)