resources: Do not update Spec.Storage.Pvc.Path

spuiuk · spuiuk · commit 391cfc929ed1 · 2022-05-19T09:50:09.000+01:00
At the moment we only support setting the PVC path at creation time. We
do not support updating the path retrospectively. Remove the code which
updates the path since this could lead to a bug.

Signed-off-by: Sachin Prabhu &lt;sprabhu@redhat.com&gt;
diff --git a/internal/planner/configuration.go b/internal/planner/configuration.go
@@ -101,9 +101,6 @@ func (pl *Planner) Update() (changed bool, err error) {
 		}
 		pl.ConfigState.Shares[shareKey] = share
 		changed = true
-	} else if share.Options["path"] != pl.Paths().Share() {
-		// Update path if changed
-		share.Options["path"] = pl.Paths().Share()
 	}
 	cfgKey := pl.instanceID()
 	cfg, found := pl.ConfigState.Configs[cfgKey]

Original file line number	Diff line number	Diff line change
`@@ -101,9 +101,6 @@ func (pl *Planner) Update() (changed bool, err error) {`
`101`	`101`	`}`
`102`	`102`	`pl.ConfigState.Shares[shareKey] = share`
`103`	`103`	`changed = true`
`104`		`- } else if share.Options["path"] != pl.Paths().Share() {`
`105`		`- // Update path if changed`
`106`		`- share.Options["path"] = pl.Paths().Share()`
`107`	`104`	`}`
`108`	`105`	`cfgKey := pl.instanceID()`
`109`	`106`	`cfg, found := pl.ConfigState.Configs[cfgKey]`