golangci-lint: enable extra checks for 'govet'

Make govet linter extra pedantic by enabling almost all checks. This in
turn revealed a minor dead-if in smbshare.

Signed-off-by: Shachar Sharon <[email protected]>

Author: synarete

.golangci.yaml

@@ -43,6 +43,12 @@ linters-settings:
   funlen:
     lines: 188
     statements: 60
+  govet:
+    check-shadowing: true
+    enable-all: true
+    disable:
+      - fieldalignment
+      - shadow
   lll:
     line-length: 98
   revive:

internal/resources/smbshare.go

@@ -324,7 +324,7 @@ func (m *SmbShareManager) Finalize(
 			m.logger.Info("Updated config map during Finalize")
 			return Requeue
 		}
-	} else if err != nil && !errors.IsNotFound(err) {
+	} else if !errors.IsNotFound(err) {
 		return Result{err: err}
 	}