Skip to content

Commit bca416c

Browse files
centosci: fix shellcheck issues
Run shellcheck on the tests/centosci scripts and fix the issues that the tool flagged. Signed-off-by: John Mulligan <[email protected]>
1 parent 06d0c26 commit bca416c

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

tests/centosci/sink-clustered-deployment.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ setup_minikube
1313

1414
deploy_rook
1515

16-
image_pull ${CI_IMG_REGISTRY} "docker.io" "golang:1.17"
16+
image_pull "${CI_IMG_REGISTRY}" "docker.io" "golang:1.17"
1717

1818
# Build and push operator image to local CI registry
1919
IMG="${CI_IMG_OP}" make image-build

tests/centosci/sink-common.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ kubectl_retry() {
7171

7272
minikube_load() {
7373
for n in ${1}; do
74-
${CONTAINER_CMD} image save ${2} | ssh \
74+
${CONTAINER_CMD} image save "${2}" | ssh \
7575
-o UserKnownHostsFile=/dev/null \
7676
-o StrictHostKeyChecking=no \
7777
-i "$(minikube ssh-key -n "$n")" \
@@ -84,6 +84,7 @@ setup_minikube() {
8484
image_pull "${CI_IMG_REGISTRY}" "docker.io" "kindest/kindnetd:v20210326-1e038dc5"
8585

8686
# Start a kuberentes cluster using minikube
87+
# shellcheck disable=SC2086
8788
minikube start --force --driver="${VM_DRIVER}" --nodes="${NODE_COUNT}" \
8889
--memory="${MEMORY}" --cpus="${CPUS}" ${DISK_CONFIG} \
8990
--delete-on-failure --install-addons=false -b kubeadm \

0 commit comments

Comments
 (0)