sambacc: add ability to write to an open file to cluster_meta_to_nodes

Add the ability to write to an already open file to
cluster_meta_to_nodes. This will allow the function to be reused later
to emit the nodes list to the stdout.

Signed-off-by: John Mulligan <[email protected]>

Author: phlogistonjohn

sambacc/commands/ctdb.py

@@ -394,9 +394,7 @@ def ctdb_must_have_node(ctx: Context) -> None:
         waiter.wait()
     if ctx.cli.write_nodes:
         _logger.info("Writing nodes file")
-        ctdb.cluster_meta_to_nodes(
-            np.cluster_meta(), real_path=np.persistent_path
-        )
+        ctdb.cluster_meta_to_nodes(np.cluster_meta(), dest=np.persistent_path)
 
 
 def _ctdb_rados_mutex_args(parser: argparse.ArgumentParser) -> None:

sambacc/ctdb.py

@@ -481,16 +481,21 @@ def _node_update(cmeta: ClusterMeta, real_path: str) -> bool:
     return True
 
 
-def cluster_meta_to_nodes(cmeta: ClusterMeta, real_path: str) -> None:
+def cluster_meta_to_nodes(
+    cmeta: ClusterMeta, dest: typing.Union[str, typing.IO]
+) -> None:
     """Write a nodes file based on the current content of the cluster
     metadata."""
     with cmeta.open(locked=True) as cmo:
         json_data = cmo.load()
         nodes = json_data.get("nodes", [])
         _logger.info("Found node metadata: %r", nodes)
         ctdb_nodes = _cluster_meta_to_ctdb_nodes(nodes)
-        _logger.info("Will write nodes: %s", ctdb_nodes)
-        _save_nodes(real_path, ctdb_nodes)
+        if isinstance(dest, str):
+            _logger.info("Will write nodes: %s", ctdb_nodes)
+            _save_nodes(dest, ctdb_nodes)
+        else:
+            write_nodes_file(dest, ctdb_nodes)
 
 
 def _cluster_meta_to_ctdb_nodes(nodes: list[dict]) -> list[str]: