commands: after ensuring share dirs, handle permissions

In the setup function and the config update function we had been
ensuring the path for the share exists. Now, we add the ability to
check/set that the share dirs also have appropriate permissions.


Signed-off-by: John Mulligan <[email protected]>

Author: phlogistonjohn

sambacc/commands/config.py

@@ -34,6 +34,7 @@
     best_leader_locator,
     best_waiter,
     commands,
+    perms_handler,
     setup_steps,
 )
 
@@ -95,6 +96,8 @@ def _update_config(
                 continue
             _logger.info(f"Ensuring share path: {path}")
             paths.ensure_share_dirs(path)
+            _logger.info(f"Updating permissions if needed: {path}")
+            perms_handler(share.permissions_config(), path).update()
     # update smb config
     if changed:
         _logger.info("Updating samba configuration")

sambacc/commands/initialize.py

@@ -24,7 +24,7 @@
 
 from . import config  # noqa: F401
 from . import users  # noqa: F401
-from .cli import commands, setup_steps, Context
+from .cli import commands, perms_handler, setup_steps, Context
 
 
 _logger = logging.getLogger(__name__)
@@ -86,7 +86,8 @@ def ensure_share_paths(ctx: Context) -> None:
             continue
         _logger.info(f"Ensuring share path: {path}")
         paths.ensure_share_dirs(path)
-        # TODO: set proper perms/acls for a "share root"
+        _logger.info(f"Updating permissions if needed: {path}")
+        perms_handler(share.permissions_config(), path).update()
 
 
 _default_setup_steps = [