Skip to content

Commit 534073c

Browse files
phlogistonjohnmergify[bot]
authored andcommitted
sambacc: add options argument to addc provision function
This will allow setting of smb.conf options at provision time. Signed-off-by: John Mulligan <[email protected]>
1 parent be09ad0 commit 534073c

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

sambacc/addc.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ def provision(
3131
admin_password: str,
3232
dns_backend: typing.Optional[str] = None,
3333
domain: typing.Optional[str] = None,
34+
options: typing.Optional[typing.Iterable[tuple[str, str]]] = None,
3435
) -> None:
3536
# this function is a direct translation of a previous shell script
3637
# as samba-tool is based on python libs, this function could possibly
@@ -43,6 +44,7 @@ def provision(
4344
admin_password=admin_password,
4445
dns_backend=dns_backend,
4546
domain=domain,
47+
options=options,
4648
)
4749
)
4850
return
@@ -95,6 +97,7 @@ def _provision_cmd(
9597
admin_password: str,
9698
dns_backend: typing.Optional[str] = None,
9799
domain: typing.Optional[str] = None,
100+
options: typing.Optional[typing.Iterable[tuple[str, str]]] = None,
98101
) -> list[str]:
99102
if not dns_backend:
100103
dns_backend = "SAMBA_INTERNAL"
@@ -110,8 +113,12 @@ def _provision_cmd(
110113
f"--realm={realm}",
111114
f"--domain={domain}",
112115
f"--adminpass={admin_password}",
113-
].argv()
114-
return cmd
116+
]
117+
for okey, oval in options or []:
118+
if okey == "netbios name":
119+
continue
120+
cmd = cmd[f"--option={okey}={oval}"]
121+
return cmd.argv()
115122

116123

117124
def _join_cmd(

0 commit comments

Comments
 (0)