Skip to content

Commit 540fcf0

Browse files
phlogistonjohnmergify[bot]
authored andcommitted
sambacc: fix constructing interface list for ctdb public_addresses
The samba wiki and documentation clearly state that the list of interfaces should be comma separated but I incorrectly joined them with spaces. Fix this and one other small suboptimal line in the same function. Signed-off-by: John Mulligan <[email protected]>
1 parent 02b6b18 commit 540fcf0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sambacc/ctdb.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,9 @@ def _write_public_addresses_file(
197197
fh: typing.IO, addrs: list[PublicAddrAssignment]
198198
) -> None:
199199
for entry in addrs:
200-
fh.write(f"{entry['address']}")
200+
fh.write(entry["address"])
201201
if entry["interfaces"]:
202-
ifaces = " ".join(entry["interfaces"])
202+
ifaces = ",".join(entry["interfaces"])
203203
fh.write(f" {ifaces}")
204204
fh.write("\n")
205205

0 commit comments

Comments
 (0)