commands: add a context property returning an opener

This opener property is the top-level point for fetching the opener to
be used for this instance of sambacc.

Signed-off-by: John Mulligan <[email protected]>

Author: phlogistonjohn

sambacc/commands/cli.py

@@ -23,6 +23,7 @@
 
 from sambacc import config
 from sambacc import leader
+from sambacc import opener
 from sambacc import permissions
 from sambacc import simple_waiter
 
@@ -142,6 +143,10 @@ def instance_config(self) -> config.InstanceConfig:
     def require_validation(self) -> typing.Optional[bool]:
         ...  # pragma: no cover
 
+    @property
+    def opener(self) -> opener.Opener:
+        ...  # pragma: no cover
+
 
 def best_waiter(
     filename: typing.Optional[str] = None,

sambacc/commands/main.py

@@ -182,6 +182,7 @@ def __init__(self, cli_args: argparse.Namespace):
         self._cli = cli_args
         self._iconfig: typing.Optional[config.InstanceConfig] = None
         self.expects_ctdb = False
+        self._opener: typing.Optional[opener.Opener] = None
 
     @property
     def cli(self) -> argparse.Namespace:
@@ -191,11 +192,10 @@ def cli(self) -> argparse.Namespace:
     def instance_config(self) -> config.InstanceConfig:
         if self._iconfig is None:
             cfgs = self.cli.config or []
-            _opener = opener.FallbackOpener([url_opener.URLOpener()])
             self._iconfig = config.read_config_files(
                 cfgs,
                 require_validation=self.require_validation,
-                opener=_opener,
+                opener=self.opener,
             ).get(self.cli.identity)
         return self._iconfig
 
@@ -207,6 +207,12 @@ def require_validation(self) -> typing.Optional[bool]:
             return False
         return None
 
+    @property
+    def opener(self) -> opener.Opener:
+        if self._opener is None:
+            self._opener = opener.FallbackOpener([url_opener.URLOpener()])
+        return self._opener
+
 
 def pre_action(cli: typing.Any) -> None:
     """Handle debugging/diagnostic related options before the target