sambacc: do not raise a KeyError if a config lacks globals

In the case of AD DC it's pretty normal for there to be no globals key
in the instance configuration. If we want to optionally support global
configuration params for addc it's convenient to simply return an empty
list rather than raise an exception in this case.  If the globals list
refers to global configs that don't exist exceptions will continue to be
raised which seem like the right thing to do.

Signed-off-by: John Mulligan <[email protected]>

Author: phlogistonjohn

sambacc/config.py

@@ -237,7 +237,11 @@ def __init__(self, conf: GlobalConfig, iconfig: dict):
     def global_options(self) -> typing.Iterable[typing.Tuple[str, str]]:
         """Iterate over global options."""
         # Pull in all global sections that apply
-        gnames = self.iconfig["globals"]
+        try:
+            gnames = self.iconfig["globals"]
+        except KeyError:
+            # no globals section in the instance means no global options
+            return
         for gname in gnames:
             global_section = self.gconfig.data["globals"][gname]
             for k, v in global_section.get("options", {}).items():