Skip to content

Commit 09432ab

Browse files
committed
smbtorture: Prefer method to find specific flapping list
samba-in-kubernetes/sit-environment#121 adds 'method' to share section in test-info.yml. With 'variant' no longer relevant, prefer 'method' to determine the need for VFS specific flapping file. Signed-off-by: Anoop C S <[email protected]>
1 parent 5426d82 commit 09432ab

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

test-info.yml.example

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,10 @@ shares:
1919
backend:
2020
# If present override default backend filesystem
2121
name: cephfs
22-
# If present list the variant of the backend filesystem
23-
variant: vfs
22+
# If present list the variant used for samba/ctdb setup
23+
variant: default
24+
# If present list the method used in share configuration
25+
method: vfs
2426
# If present, use these credentials to perform the
2527
# tests for this share
2628
users:

testcases/smbtorture/test_smbtorture.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323

2424
def flapping_file(backend: str, variant: str = "") -> str:
2525
file = "flapping." + backend
26-
if variant and variant != "default":
27-
file_variant = f"{file}-{variant}"
26+
if variant and "vfs" in variant:
27+
file_variant = f"{file}-vfs"
2828
if os.path.exists(os.path.join(selftest_dir, file_variant)):
2929
return file_variant
3030
if os.path.exists(os.path.join(selftest_dir, file)):
@@ -62,7 +62,11 @@ def smbtorture(share_name: str, test: str, tmp_output: Path) -> bool:
6262
flapping_list = ["flapping", "flapping.d"]
6363
share = testhelper.get_share(test_info, share_name)
6464
test_backend = share["backend"].get("name")
65-
test_backend_variant = share["backend"].get("variant")
65+
test_backend_variant = (
66+
share["backend"].get("method")
67+
if share["backend"].get("method") is not None
68+
else share["backend"].get("variant")
69+
)
6670
if test_backend is not None:
6771
file = flapping_file(test_backend, test_backend_variant)
6872
if file is not None:

0 commit comments

Comments
 (0)