Skip to content

Commit f268c1e

Browse files
spuiukspuiuk
committed
smbtorture: update selftest files
This includes a new subdirectory expectedfail.d which includes all tests expected to always fail. Head of samba repo when this copy was made 0caaa2d1723 (vfs: Remove shadow_copy2_get_real_filename_at(), 2024-01-11) Signed-off-by: Sachin Prabhu <[email protected]>
1 parent bec6556 commit f268c1e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+467
-264
lines changed

‎testcases/smbtorture/selftest/README

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
Scripts and modules copied over from the samba source tree.
22

33
At the time of copy, the samba head is at
4-
7938d94d12e s4-selftest: add net offlinejoin tests
4+
0caaa2d1723 (vfs: Remove shadow_copy2_get_real_filename_at(), 2024-01-11)

‎testcases/smbtorture/selftest/expectedfail.d/README

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Files in this directory contain lists of regular expressions
2+
# matching the names of tests that are *necessarily* expected to fail.
3+
#
4+
# "make test" will not report failures for tests listed here and will
5+
# consider a successful run for any of these tests an error.
6+
#
7+
# They differ from the knownfail tests (selftest/knownfail.d) in that
8+
# the lack of failure here is definitely a problem. The knownfail
9+
# tests might be fixed one day, even accidentally, but these ones will
10+
# not.
11+
#
12+
# Before adding tests here, consider rewriting the test so that the
13+
# expected result is a failure. The tests in here are typically
14+
# testing the use of some protocol or feature on a server that has
15+
# that feature turned off. The same tests will also be run against
16+
# another server where they do not fail. The downside of this method
17+
# is we don't know that these expected fail tests are failing in the
18+
# right way.
19+
#
20+
# Empty lines and lines beginning with '#' are ignored.
21+
#
22+
# Please don't add tests to this README!

‎testcases/smbtorture/selftest/expectedfail.d/encrypted_secrets

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# The fl2000dc environment is provisioned with the --plaintext-secrets option
2+
# running the ecnrypted secrets tests on it and expecting them to fail.
3+
# verifies that:
4+
# * --plaintext-secrets option correctly provisions a domain
5+
# * the dsdb operational module correctly handles unencrypted secrets
6+
# * secrets are not stored as encrypted text when this option is specified
7+
^samba.tests.encrypted_secrets.samba.tests.encrypted_secrets.EncryptedSecretsTests.test_encrypted_secrets\(fl2000dc:local\)
8+
^samba.tests.encrypted_secrets.samba.tests.encrypted_secrets.EncryptedSecretsTests.test_required_features\(fl2000dc:local\)
9+
#
10+
# The tests for bug 13563 https://bugzilla.samba.org/show_bug.cgi?id=13653
11+
# should fail in the mdb case, as sam.ldb is currently a tdb file.
12+
#
13+
^samba.tests.blackbox.bug13653.samba.tests.blackbox.bug13653.Bug13653Tests.test_mdb_scheme

‎testcases/smbtorture/selftest/expectedfail.d/labdc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Because the lab-DC testenv scrubs all user info (apart from the Admin),
2+
# we expect tests relying on other users' credentials to fail.
3+
# These tests fail because they use testallowed and testdenied users.
4+
^samba4.rpc.echo.testallowed.*labdc.*
5+
^samba4.rpc.echo.testdenied.*labdc.*

‎testcases/smbtorture/selftest/expectedfail.d/ntlm-auth

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# NETLOGON is disabled in any non-DC environments
2+
^samba.tests.netlogonsvc.python\(ad_member\)
3+
^samba.tests.netlogonsvc.python\(simpleserver\)
4+
^samba.tests.netlogonsvc.python\(fileserver\)
5+
# NETLOGON is disabled in any non-DC environments
6+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_2nd_cancel_requests\(ad_member\)
7+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_first_08_requests\(ad_member\)
8+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_first_cancel_requests\(ad_member\)
9+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_first_cmpx_requests\(ad_member\)
10+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_first_didnot_requests\(ad_member\)
11+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_first_maybe_requests\(ad_member\)
12+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_first_only_requests\(ad_member\)
13+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_fragmented_requests01\(ad_member\)
14+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_fragmented_requests02\(ad_member\)
15+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_fragmented_requests03\(ad_member\)
16+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_fragmented_requests04\(ad_member\)
17+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_fragmented_requests05\(ad_member\)
18+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_last_cancel_requests\(ad_member\)
19+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_last_only_requests\(ad_member\)
20+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_mix_requests\(ad_member\)
21+
^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_none_only_requests\(ad_member\)

‎testcases/smbtorture/selftest/expectedfail.d/ntlmdisabled

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# NTLM authentication is (intentionally) disabled in ktest
2+
^samba.tests.ntlmdisabled.python\(ktest\).ntlmdisabled.NtlmDisabledTests.test_ntlm_connection\(ktest\)
3+
^samba.tests.ntlmdisabled.python\(ad_dc_no_ntlm\).ntlmdisabled.NtlmDisabledTests.test_samr_change_password\(ad_dc_no_ntlm\)
4+
# Disabling NTLM means you can't use samr to change the password
5+
^samba.tests.ntlmdisabled.python\(ktest\).ntlmdisabled.NtlmDisabledTests.test_samr_change_password\(ktest\)
6+
^samba.tests.ntlmdisabled.python\(ad_dc_no_ntlm\).ntlmdisabled.NtlmDisabledTests.test_ntlm_connection\(ad_dc_no_ntlm\)

‎testcases/smbtorture/selftest/expectedfail.d/ntlmv1-restrictions

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# These tests should fail in these environments, as we restrict NTLMv1
2+
# in both of these, with vampire_dc however allowing MSCHAPv2
3+
samba.tests.py_credentials.samba.tests.py_credentials.PyCredentialsTests.test_SamLogonExNTLM\(vampire_dc\)
4+
samba.tests.py_credentials.samba.tests.py_credentials.PyCredentialsTests.test_SamLogonExMSCHAPv2\(promoted_dc\)
5+
samba.tests.py_credentials.samba.tests.py_credentials.PyCredentialsTests.test_SamLogonExNTLM\(promoted_dc\)

‎testcases/smbtorture/selftest/expectedfail.d/samba-4.5-emulation

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# This fails as there is no second DC in this environment, so it is always the owner
2+
samba4.drs.getnc_exop.python\(chgdcpass\).getnc_exop.DrsReplicaSyncTestCase.test_FSMONotOwner\(chgdcpass\)
3+
# This fails because GET_ANC is now poorly implemented (matching Samba 4.5)
4+
^samba4.drs.getnc_exop.python\(chgdcpass\).getnc_exop.DrsReplicaSyncTestCase.test_link_utdv_hwm\(chgdcpass\)

‎testcases/smbtorture/selftest/flapping.d/nbt_dgram

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# following SMB1/SMB2 test env split it seems this test
22
# fails randomly however it doesn't seem to be directly
3-
# related to the changes (e.g. not protocl negotiation
3+
# related to the changes (e.g. not protocol negotiation
44
# specific) Best guess is the order of test having being
55
# changed (as a result of test moving env) or some other
66
# strange env related side affect is causing this.

‎testcases/smbtorture/selftest/flapping.d/smb2-multichannel

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# https://bugzilla.samba.org/show_bug.cgi?id=15498
2+
# This test often times out in CI.
3+
^samba3\.smb2\.multichannel\.bugs\.bug_15346\(nt4_dc\)$

0 commit comments

Comments
 (0)