Skip to content

Commit 23b3e23

Browse files
committed
metrics: extend test with output from OpenShift cluster
Using real-life output from OpenShift cluster for metrics unit-tests. Signed-off-by: Shachar Sharon <[email protected]>
1 parent 4322db0 commit 23b3e23

File tree

1 file changed

+25
-8
lines changed

1 file changed

+25
-8
lines changed

internal/metrics/smbstatus_test.go

Lines changed: 25 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,15 @@ var (
1919
share_test2 13669 10.66.208.149 Wed Sep 27 10:35:56 AM 2022 CST - -
2020
IPC$ 651248 10.0.0.100 Sat Sep 4 10:37:01 AM 2020 MDT - -
2121
22+
`
23+
24+
outputSmbStatusS2 = `
25+
26+
Service pid Machine Connected at Encryption Signing
27+
---------------------------------------------------------------------------------------------
28+
samba-share 295 ::1 Thu Apr 7 14:33:19 2022 UTC - -
29+
IPC$ 295 ::1 Thu Apr 7 14:33:19 2022 UTC - -
30+
2231
`
2332

2433
outputSmbStatusp = `
@@ -44,15 +53,23 @@ Pid User(ID) DenyMode Access R/W Oplock Share
4453
//revive:enable line-length-limit
4554

4655
func TestParseSmbStatusShares(t *testing.T) {
47-
locks, err := parseSmbStatusShares(outputSmbStatusS)
56+
shares, err := parseSmbStatusShares(outputSmbStatusS)
4857
assert.NoError(t, err)
49-
assert.Equal(t, len(locks), 2)
50-
lock1 := locks[0]
51-
assert.Equal(t, lock1.Service, "share_test")
52-
assert.Equal(t, lock1.PID, int64(13668))
53-
assert.Equal(t, lock1.Machine, "10.66.208.149")
54-
assert.Equal(t, lock1.Encryption, "-")
55-
assert.Equal(t, lock1.Signing, "-")
58+
assert.Equal(t, len(shares), 2)
59+
share1 := shares[0]
60+
assert.Equal(t, share1.Service, "share_test")
61+
assert.Equal(t, share1.PID, int64(13668))
62+
assert.Equal(t, share1.Machine, "10.66.208.149")
63+
assert.Equal(t, share1.Encryption, "-")
64+
assert.Equal(t, share1.Signing, "-")
65+
66+
shares, err = parseSmbStatusShares(outputSmbStatusS2)
67+
assert.NoError(t, err)
68+
assert.Equal(t, len(shares), 1)
69+
share1 = shares[0]
70+
assert.Equal(t, share1.Service, "samba-share")
71+
assert.Equal(t, share1.PID, int64(295))
72+
assert.Equal(t, share1.Machine, "::1")
5673
}
5774

5875
func TestParseSmbStatusProcs(t *testing.T) {

0 commit comments

Comments
 (0)