metrics: create new SMBStatus via helper func

Use convenience helper function with all-empty fields by default. In
particular, internal maps.

Signed-off-by: Shachar Sharon <[email protected]>

Author: synarete

internal/metrics/smbstatus.go

@@ -205,9 +205,9 @@ func executeCommand(command string, arg ...string) (string, error) {
 // parseSMBStatus parses to output of 'smbstatus --json' into internal
 // representation.
 func parseSMBStatus(data string) (*SMBStatus, error) {
-	res := SMBStatus{}
-	err := json.Unmarshal([]byte(data), &res)
-	return &res, err
+	res := NewSMBStatus()
+	err := json.Unmarshal([]byte(data), res)
+	return res, err
 }
 
 // parseSMBStatusLocks parses to output of 'smbstatus --locks --json' into
@@ -217,3 +217,16 @@ func parseSMBStatusLocks(data string) (*SMBStatusLocks, error) {
 	err := json.Unmarshal([]byte(data), &res)
 	return &res, err
 }
+
+// NewSMBStatus returns non-populated SMBStatus object
+func NewSMBStatus() *SMBStatus {
+	smbStatus := SMBStatus{
+		Timestamp:   "",
+		Version:     "",
+		SmbConf:     "",
+		Sessions:    map[string]SMBStatusSession{},
+		TCons:       map[string]SMBStatusTreeCon{},
+		LockedFiles: map[string]SMBStatusLockedFile{},
+	}
+	return &smbStatus
+}