lint

Author: sambaiz

.eslintrc.js

@@ -0,0 +1,6 @@
+module.exports = {
+    "extends": "google",
+    "parserOptions": {
+    	"ecmaVersion": 2017,
+    }
+};

README.md

@@ -32,4 +32,4 @@ Once you build it, link to `headless_shell.tar.gz` in `chrome` dir.
 
 ## Article
 
-[PuppeteerでHeadless Chromeを動かすコードをLambdaで実行する - sambaiz-net](https://www.sambaiz.net/article/132/)
+[Lambda上でPuppeteer/Headless Chromeを動かすBoilerplateを作った - sambaiz-net](https://www.sambaiz.net/article/132/)

package-lock.json

@@ -1,10 +1,11 @@
 {
   "scripts": {
-    "package": "npm run package-ready && cp chrome/headless_shell.tar.gz dist && cd dist && zip -rq ../package.zip .",
-    "package-nochrome": "npm run package-ready && zip -rq ../package.zip .",
-    "package-ready": "npm run babel && cp -r package.json dist && cd dist && PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 npm install --production",
+    "package": "npm run package-prepare && cp chrome/headless_shell.tar.gz dist && cd dist && zip -rq ../package.zip .",
+    "package-nochrome": "npm run package-prepare && zip -rq ../package.zip .",
+    "package-prepare": "npm run lint && npm run babel && cp -r package.json dist && cd dist && PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 npm install --production",
     "babel": "rm -rf dist && mkdir dist && ./node_modules/.bin/babel src --out-dir dist",
-    "local": "npm run babel && cp -r node_modules dist && node dist/local.js"
+    "local": "npm run babel && cp -r node_modules dist && node dist/local.js",
+    "lint": "./node_modules/.bin/eslint src"
   },
   "dependencies": {
     "puppeteer": "^0.10.2",
@@ -13,6 +14,8 @@
   "devDependencies": {
     "aws-sdk": "^2.111.0",
     "babel-cli": "^6.26.0",
-    "babel-preset-env": "^1.6.0"
+    "babel-preset-env": "^1.6.0",
+    "eslint": "^4.6.1",
+    "eslint-config-google": "^0.9.1"
   }
 }

package.json

@@ -1,8 +1,8 @@
 exports.launchOptionForLambda = [
-        // error when launch(); No usable sandbox! Update your kernel
-        '--no-sandbox',
-        // error when launch(); Failed to load libosmesa.so
-        '--disable-gpu', 
-        // freeze when newPage()
-        '--single-process'
-      ];
+    // error when launch(); No usable sandbox! Update your kernel
+    '--no-sandbox',
+    // error when launch(); Failed to load libosmesa.so
+    '--disable-gpu',
+    // freeze when newPage()
+    '--single-process',
+];

src/config.js

@@ -1,33 +1,32 @@
-const puppeteer = require('puppeteer'),
-      config = require('./config'),
-      util = require('./util');
+const puppeteer = require('puppeteer');
+const config = require('./config');
+const util = require('./util');
 
 exports.handler = async (event, context, callback) => {
   exports.run({
     headless: true,
-    chromePath: await util.setupChrome()
+    chromePath: await util.setupChrome(),
   }).then(
-    (result) => { callback(null, result); }
+    (result) => callback(null, result)
   ).catch(
-    (err)    => { callback(err); }
-  )
-}
+    (err) => callback(err)
+  );
+};
 
 exports.run = async (option) => {
-
   const browser = await puppeteer.launch({
     headless: option.headless,
     executablePath: option.chromePath,
     slowMo: option.slowMoMs,
     args: config.launchOptionForLambda,
     dumpio: !!util.DEBUG,
-  });  
+  });
+
+  util.debugLog(`Chrome launched, version ${await browser.version()}`);
 
-  util.debugLog(`Chrome launched, version ${await browser.version()}`)
-  
   const page = await browser.newPage();
   await page.goto('https://www.google.co.jp');
   browser.close();
 
-  return 'done'
-}
+  return 'done';
+};

src/index.js

@@ -5,7 +5,7 @@ index.run({
     slowMoMs: 250,
     // use chrome installed by puppeteer
 }).then(
-    (result) => { console.log(result); }
+    (result) => console.log(result)
 ).catch(
-    (err)    => { console.error(err); }
-);
+    (err) => console.error(err)
+);

src/local.js

@@ -1,13 +1,13 @@
-const CHROME_BUCKET = process.env.CHORME_BUCKET,
-      CHROME_KEY    = process.env.CHROME_KEY || 'headless_shell.tar.gz',
-      aws       = require('aws-sdk'),      
-      s3        = new aws.S3({ apiVersion: '2006-03-01' }),
-      fs        = require('fs'),
-      tar       = require('tar'),
-      path      = require('path'),
+const CHROME_BUCKET = process.env.CHORME_BUCKET;
+const CHROME_KEY = process.env.CHROME_KEY || 'headless_shell.tar.gz';
+const aws = require('aws-sdk');
+const s3 = new aws.S3({apiVersion: '2006-03-01'});
+const fs = require('fs');
+const tar = require('tar');
+const path = require('path');
 
-      localChromePath = path.join('headless_shell.tar.gz'),
-      setupChromePath = path.join(path.sep, 'tmp');
+const localChromePath = path.join('headless_shell.tar.gz');
+const setupChromePath = path.join(path.sep, 'tmp');
 
 exports.DEBUG = process.env.DEBUG;
 
@@ -17,13 +17,13 @@ exports.setupChrome = async () => {
       exports.debugLog('setup local chrome');
       await setupLocalChrome();
     } else {
-      exports.debugLog('setup s3 chrome')
+      exports.debugLog('setup s3 chrome');
       await setupS3Chrome();
     }
     exports.debugLog('setup done');
   }
   return executablePath;
-}
+};
 
 const executablePath = path.join(
   setupChromePath,
@@ -34,45 +34,45 @@ const existsLocalChrome = () => {
   return new Promise((resolve, reject) => {
     fs.exists(localChromePath, (exists) => {
       resolve(exists);
-    })
+    });
   });
-}
+};
 
 const existsExecutableChrome = () => {
   return new Promise((resolve, reject) => {
     fs.exists(executablePath, (exists) => {
       resolve(exists);
-    })
+    });
   });
-}
+};
 
 const setupLocalChrome = () => {
     return new Promise((resolve, reject) => {
       console.log(localChromePath);
       fs.createReadStream(localChromePath)
-      .on('error', err => { reject(err); })
+      .on('error', (err) => reject(err))
       .pipe(tar.x({
-        C: setupChromePath
+        C: setupChromePath,
       }))
-      .on('error', err => { reject(err); })
-      .on('end', () => { resolve(); });
+      .on('error', (err) => reject(err))
+      .on('end', () => resolve());
     });
-}
-  
+};
+
 const setupS3Chrome = () => {
     return new Promise((resolve, reject) => {
       const params = {Bucket: CHROME_BUCKET, Key: CHROME_KEY};
       s3.getObject(params)
       .createReadStream()
-      .on('error', err => { reject(err); })
+      .on('error', (err) => reject(err))
       .pipe(tar.x({
-        C: setupChromePath
+        C: setupChromePath,
       }))
-      .on('error', err => { reject(err); })
-      .on('end', () => { resolve(); });
+      .on('error', (err) => reject(err))
+      .on('end', () => resolve());
     });
-}
+};
 
 exports.debugLog = (log) => {
-    if(exports.DEBUG) console.log(log)
-}
+    if (exports.DEBUG) console.log(log);
+};