Merge pull request rubocop#1466 from davidrunger/avoid-warnings-about-redefined-methods

Avoid warnings about redefined methods in EnforceSuperclass module

Author: koic

changelog/fix_avoid_warnings_about_redefined_methods.md

@@ -0,0 +1 @@
+* [#1465](https://github.com/rubocop/rubocop-rails/issues/1465): Avoid warnings about methods of `RuboCop::Cop::EnforceSuperclass` being redefined. ([@davidrunger][])

lib/rubocop/cop/mixin/enforce_superclass.rb

@@ -1,7 +1,12 @@
 # frozen_string_literal: true
 
 module RuboCop
-  module Cop
+  module Cop # rubocop:disable Style/Documentation
+    # The EnforceSuperclass module is also defined in `rubocop` (for backwards
+    # compatibility), so here we remove it before (re)defining it, to avoid
+    # warnings about methods in the module being redefined.
+    remove_const(:EnforceSuperclass) if defined?(EnforceSuperclass)
+
     # Common functionality for enforcing a specific superclass.
     module EnforceSuperclass
       def self.included(base)