Skip to content

Commit 43277d7

Browse files
committed
Cut 2.17.2
1 parent 964268c commit 43277d7

File tree

5 files changed

+19
-29
lines changed

5 files changed

+19
-29
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## master (unreleased)
44

5+
## 2.17.2 (2022-10-27)
6+
57
### Bug fixes
68

79
* [#825](https://github.com/rubocop/rubocop-rails/issues/825): Fix a false positive for `Rails/ActionControllerFlashBeforeRender` when using condition before `redirect_to`. ([@koic][])

docs/antora.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ name: rubocop-rails
22
title: RuboCop Rails
33
# We always provide version without patch here (e.g. 1.1),
44
# as patch versions should not appear in the docs.
5-
version: ~
5+
version: '2.17'
66
nav:
77
- modules/ROOT/nav.adoc

docs/modules/ROOT/pages/cops_rails.adoc

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
| Pending
99
| Yes
10-
| Yes
10+
| Yes (Unsafe)
1111
| 2.16
1212
| -
1313
|===
@@ -41,16 +41,6 @@ class HomeController < ApplicationController
4141
end
4242
----
4343

44-
=== Configurable attributes
45-
46-
|===
47-
| Name | Default value | Configurable values
48-
49-
| SafeAutocorrect
50-
| `false`
51-
| Boolean
52-
|===
53-
5444
=== References
5545

5646
* https://rails.rubystyle.guide/#flash-before-render
@@ -63,7 +53,7 @@ end
6353

6454
| Pending
6555
| Yes
66-
| Yes
56+
| Yes (Unsafe)
6757
| 2.14
6858
| -
6959
|===
@@ -95,10 +85,6 @@ end
9585
|===
9686
| Name | Default value | Configurable values
9787

98-
| SafeAutocorrect
99-
| `false`
100-
| Boolean
101-
10288
| Include
10389
| `+**/test/**/*.rb+`
10490
| Array
@@ -5039,7 +5025,7 @@ Rails.public_path.join('path', to, 'file.pdf')
50395025

50405026
| Pending
50415027
| Yes
5042-
| Yes
5028+
| Yes (Unsafe)
50435029
| 2.16
50445030
| -
50455031
|===
@@ -5078,16 +5064,6 @@ Rails.root.join('db', 'schema.rb').write(content)
50785064
Rails.root.join('db', 'schema.rb').binwrite(content)
50795065
----
50805066

5081-
=== Configurable attributes
5082-
5083-
|===
5084-
| Name | Default value | Configurable values
5085-
5086-
| SafeAutocorrect
5087-
| `false`
5088-
| Boolean
5089-
|===
5090-
50915067
== Rails/RootPublicPath
50925068

50935069
|===

lib/rubocop/rails/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ module RuboCop
44
module Rails
55
# This module holds the RuboCop Rails version information.
66
module Version
7-
STRING = '2.17.1'
7+
STRING = '2.17.2'
88

99
def self.document_version
1010
STRING.match('\d+\.\d+').to_s

relnotes/v2.17.2.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
### Bug fixes
2+
3+
* [#825](https://github.com/rubocop/rubocop-rails/issues/825): Fix a false positive for `Rails/ActionControllerFlashBeforeRender` when using condition before `redirect_to`. ([@koic][])
4+
* [#833](https://github.com/rubocop/rubocop-rails/issues/833): Fix a false positive for `Rails/Pluck` when receiver is not block argument for `[]`. ([@koic][])
5+
* [#834](https://github.com/rubocop/rubocop-rails/issues/834): Fix an error for `Rails/WhereNotWithMultipleConditions` when using `where.not` with empty hash literal. ([@koic][])
6+
* [#833](https://github.com/rubocop/rubocop-rails/issues/833): Fix a false positive for `Rails/Pluck` when using multiple block arguments. ([@koic][])
7+
8+
### Changes
9+
10+
* [#832](https://github.com/rubocop/rubocop-rails/issues/832): Mark `Rails/ActionControllerFlashBeforeRender`, `Rails/ActionControllerTestCase`, and `Rails/RootPathnameMethods` cops as unsafe autocorrection. ([@koic][])
11+
12+
[@koic]: https://github.com/koic

0 commit comments

Comments
 (0)