Merge pull request rubocop#784 from koic/fix_an_incorrect_autocorrect_for_rails_eager_evaluation_log_message

[Fix rubocop#782] Fix an incorrect autocorrect for `Rails/EagerEvaluationLogMessage`

Author: koic

changelog/fix_an_incorrect_autocorrect_for_rails_eager_evaluation_log_message.md

@@ -0,0 +1 @@
+* [#782](https://github.com/rubocop/rubocop-rails/issues/782): Fix an incorrect autocorrect for `Rails/EagerEvaluationLogMessage` when using `Style/MethodCallWithArgsParentheses`'s autocorrection together. ([@koic][])

lib/rubocop-rails.rb

@@ -14,6 +14,14 @@
 
 require_relative 'rubocop/cop/rails_cops'
 
+RuboCop::Cop::Style::MethodCallWithArgsParentheses.singleton_class.prepend(
+  Module.new do
+    def autocorrect_incompatible_with
+      super.push(RuboCop::Cop::Rails::EagerEvaluationLogMessage)
+    end
+  end
+)
+
 RuboCop::Cop::Style::RedundantSelf.singleton_class.prepend(
   Module.new do
     def autocorrect_incompatible_with

lib/rubocop/cop/rails/eager_evaluation_log_message.rb

@@ -37,6 +37,10 @@ class EagerEvaluationLogMessage < Base
           )
         PATTERN
 
+        def self.autocorrect_incompatible_with
+          [Style::MethodCallWithArgsParentheses]
+        end
+
         def on_send(node)
           return if node.parent&.block_type?
 

spec/rubocop/cli/autocorrect_spec.rb

@@ -9,6 +9,22 @@
     RuboCop::ConfigLoader.default_configuration.for_all_cops['SuggestExtensions'] = false
   end
 
+  it 'corrects `Rails/EagerEvaluationLogMessage,` with `Style/MethodCallWithArgsParentheses`' do
+    create_file('.rubocop.yml', <<~YAML)
+      Rails/SafeNavigation:
+        ConvertTry: true
+    YAML
+
+    create_file('example.rb', <<~'RUBY')
+      Rails.logger.debug "foo#{bar}"
+    RUBY
+
+    expect(cli.run(['-a', '--only', 'Rails/EagerEvaluationLogMessage,Style/MethodCallWithArgsParentheses'])).to eq(0)
+    expect(File.read('example.rb')).to eq(<<~'RUBY')
+      Rails.logger.debug { "foo#{bar}" }
+    RUBY
+  end
+
   it 'corrects `Rails/SafeNavigation` with `Style/RedundantSelf`' do
     create_file('.rubocop.yml', <<~YAML)
       Rails/SafeNavigation: