MaraDNS bug report thread

[samboy]

This thread is for reporting MaraDNS bugs without a security impact. Use the MaraDNS security report thread for security bugs.

[maddadder]

In Windows it seemed like in the dwood3rc.txt file, the service would fail to load if there is no line break at the end of the file

[samboy]

It’s not a bug. It’s a feature. Here’s the relevant code in DwMararc.c:

                if(feof(look) && last != '\r' && last != '\n') {
                        ret = -3; /* Premature EOF; incomplete last line */
                        goto catch_dwm_parse_line;
                }

Then, we have this, also in DwMararc.c

                if(a == -3) {
                        dwm_fatal("incomplete last line");
                }

It’s an aesthetic thing; a proper editor should put an end of line at the end of the file. If this bothers you, remove the above code (EDIT probably best to change the second block of code to give a warning, not a fatal error) and recompile Deadwood.

Having a fairly strict parser minimizes the chances of a malformed file resulting in undefined behavior.

[samboy]

I have made incomplete last lines non-fatal in commit e47aaaf

[samboy]

maradns-win32/Deadwood.exe updated in commit b51d865

Note that this .exe doesn’t have a usable version number, but the Deadwood.exe has a md5sum of 2c16756827ed3d5c9897c6a336bd8637 or a SHA-256 sum of b798ffd60471c9e4867e03363408a1409f8791c604629e4c610d587cfc12426b (Yes, I am aware MD5 has been broken, but a lot of Windows users still use it for insecure checksum values)

[samboy]

Test results: commit b51d865 passes all tests

I still need to hand test things in Windows.

Also: This isn’t a big enough change to warrant a new release immediately.

[samboy]

Deadwood.exe now has version number "2022-03-15" as of b3619dd

[msimerson]

On the csv2 page, the examples for the SPF record are missing the terminating ~.

[samboy]

Fixed, see below, thank you for the report. Also, added a CAA example while updating that page.

[samboy]

Fixed in commit bd6a4f4 and commit f0b6e23

I’ve also added a CAA example to the linked page.

[msimerson]

Another bug in the csv2 docs, fd4d:6172:6144:4e53:1:2:3::4:f is not valid IPv6.

[msimerson]

If the dns class IN is allowed, then the definition of an RR atop the page should reflect it as being optional.

[samboy]

I should replace the fd4d:6172 stuff with 2001:0db8 addresses (2001:0db8/32 is a special “bogus IPv6 to use in documentation” which I didn’t know about 15 years ago when I wrote the documents you are going over).

[msimerson]

👏 from the README.md over at dns-resource-record

[samboy]

The documentation examples now all use 2001:db8 addresses in MaraDNS. I mostly fixed this a few months ago in commit 05b48c9 but two final examples using the older fd4d stuff were still around, but this has been fixed in commit 9013fb2

[samboy]

Updates:

• I have updated the IPv6 documentation examples to use the official 2001:db8 prefix one uses for IPv6 documentation.
• I have added a brief note explaining what “IN” means to MaraDNS’s CSV2 parser

See: commit c737d22 commit b6a8168 commit c4cbafe commit 8558837 and commit 05b48c9

[samboy]

Locking discussion to stop spam bots. If you have an issue, start a new discussion.