-
-
Notifications
You must be signed in to change notification settings - Fork 96
Instructure Patches #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Instructure Patches #1879
Conversation
|
I'm also not sure how much we want to tie ourselves to Natsumi, the sidebar is completely illegible to me (using stock Zen rn, but Nebula also doesn't have |
|
Yeah, sorry that was my first time contributing to this and I wasn't sure what way the blur effect was being achieved or what the protocol was. I'm mapping it to my school's subdomain in the advanced settings. I modeled it on my browser using the "high contrast mode" that's found in the profile sidebar section. Anyways, the reason I was coming was to add this for darkreader since it's required to be on but when it's on the background is not transparent. See if you can review this or if you think it makes sense here, and tell me if you wanna add it to one of your commits since you already have a PR open or if you want me to make another one, thank you. /* darkreader */ |
Nah, you're good! Everybody starts somewhere (I think this is honestly my first PR here? I usually just use ubo if I want to override it.)
That shouldn't be necessary? It works fine for me without that. 🤔
Good to know, thanks for the tip!
Yeah, that's what I've been working on. I use BetterCanvas's Dark mode (I do use Dark Reader, but I turned it off for Canvas) but it's AGPL so I can't just
Just cause it'd conflict I guess I'll go ahead and add it in, but I'll be sure to mark you as the commit author. |
Also, I patched Nebula to fix (most of) the bugs I was hitting in 3.3, so it does work now, although only by accident. Nebula doesn't scope the PDF reader code it borrowed from Natsumi, so |
|
Could just copy and paste to replace that line with the --natsumi-glass-background value: |
Oh, I understand the problem! Issue #1884 has the same problem and the solution is to rename the file to "+instructure.com.css" |
Yeah, but that depends on |
Yeah, I figured it was one of the prefixes. 👍🏻 |
|
Ok, you can set your custom CSS URL to |
If you install BetterCanvas, it now piggybacks on its CSS when available. Make sure you install BetterCanvas, not BetterCampus. They took the extension closed-source, made it Chromium exclusive (tho they use WXT so not sure what they're doing?), and rewrote dark mode; I'm not supporting it. I assume you're consuming this via a Firefox fork (e.g., Zen), so probably not an issue, but worth noting.
WRT licensing—first off, BetterCanvas is not AGPL, it's MIT. They slapped AGPL on it when they closed-sourced it to make it look scary, but that just retrospectively dual-licenses it. It doesn't remove the fact that it's also MIT. |
|
What is stopping this from being merged? |
At bare minimum, I've found a few more classes after daily-driving this for a few months now. |
e72c986 to
b071fbf
Compare
|
Can you resolve the small conflict in the readme, I did not know that file was updated in this PR so I merged another one. |
5ecdefd to
b0d84bf
Compare
Yeah, probably should've made a different PR. Rebased it, should be good to go now. |
Follow up to #1819.
Closes #1884