Skip to content

Commit e921ce8

Browse files
authored
Merge pull request #1925 from emon/oauth_saml_attribute_statements
fix gitlab_configure_oauth_saml_attribute_statements()
2 parents fb816a0 + 8d9ab93 commit e921ce8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

assets/runtime/functions

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -564,12 +564,12 @@ gitlab_configure_oauth_bitbucket() {
564564
}
565565

566566
gitlab_configure_oauth_saml_attribute_statements() {
567-
if [[ -n ${OAUTH_SAML_ATTRIBUTE_STATEMENTS_EMAIL} && \
568-
-n ${OAUTH_SAML_ATTRIBUTE_STATEMENTS_NAME} ]]; then
567+
if [[ -n ${OAUTH_SAML_ATTRIBUTE_STATEMENTS_EMAIL} ]]; then
569568
echo "Configuring gitlab::oauth::saml::attribute_statements..."
570569
update_template ${GITLAB_CONFIG} \
571570
OAUTH_SAML_ATTRIBUTE_STATEMENTS_EMAIL \
572571
OAUTH_SAML_ATTRIBUTE_STATEMENTS_NAME \
572+
OAUTH_SAML_ATTRIBUTE_STATEMENTS_USERNAME \
573573
OAUTH_SAML_ATTRIBUTE_STATEMENTS_FIRST_NAME \
574574
OAUTH_SAML_ATTRIBUTE_STATEMENTS_LAST_NAME
575575
# Remove undefined optional attributes

0 commit comments

Comments
 (0)