Skip to content

fix: return empty json instead of throwing error on empty response #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlosmiei merged 2 commits into from
Feb 26, 2025
Merged

fix: return empty json instead of throwing error on empty response #1554

carlosmiei merged 2 commits into from
Feb 26, 2025

Conversation

@pcriadoperez
Copy link
Collaborator

@pcriadoperez pcriadoperez commented Feb 16, 2025 •
edited
Loading

Problem

  • Some endpoints return a status.code 200 with an empty response. Here the library was throwing a ValueError.
  • Fixes pyright error for get_all_tickers

Solution

Return an empty json in case of an empty response

@pcriadoperez pcriadoperez self-assigned this Feb 16, 2025
@pcriadoperez pcriadoperez mentioned this pull request Feb 16, 2025
Merged
@carlosmiei carlosmiei closed this Feb 19, 2025
@carlosmiei carlosmiei reopened this Feb 19, 2025
@pcriadoperez pcriadoperez mentioned this pull request Feb 25, 2025
Merged
@carlosmiei carlosmiei merged commit d12d6a9 into sammchardy:master Feb 26, 2025
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosmiei carlosmiei Awaiting requested review from carlosmiei carlosmiei is a code owner

Assignees

@pcriadoperez pcriadoperez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pcriadoperez @carlosmiei