Vec<u8> does not work for binary data

[exedealer]

seems that Vec<u8> does not work for binary data. But doc says it should

[samscott89]

Hey @exedealer can you elaborate on what's not working? There are numerous test cases in https://github.com/samscott89/serde_qs/blob/main/tests/test_roundtrip.rs for Vec<u8>

[exedealer]

I expected this to work,

fn main() {

    #[derive(serde::Deserialize)]
    struct Params {
        greeting: Vec<u8>,
    }

    let Params { greeting } = serde_qs::from_str("greeting=hello_%ff_world").unwrap();

    debug_assert!(greeting == b"hello_\xff_world");
}

thread 'main' (482279) panicked at be/main_qs.rs:7:78:
called `Result::unwrap()` on an `Err` value: Utf8(Utf8Error { valid_up_to: 6, error_len: Some(1) })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[exedealer]

As I understand it, Vec<u8> is not meant to work for deserializing bytes from percent-encoded strings. That is the case for std::ffi::CString or the unstable ByteString. So this is a documentation issue; the documentation is a bit misleading.

[samscott89]

Ahh, I see what you mean. Yeah the documentation is not clear. The following works nicely though: https://github.com/samscott89/serde_qs/blob/main/tests/test_roundtrip.rs#L1501-L1502
e.g. https://github.com/samscott89/serde_qs/blob/main/tests/snapshots/bytes_types%40query.snap

[0, 1, 2, 255, 128, 64] -> %00%01%02%FF%80@ (and round-trips back). So that would probably work well for your use case? Thanks for raising!