Merge pull request #34 from samsonasik/faster-splfixedarray

Make faster search on Finder::last() on SplFixedArray data

Author: samsonasik

src/Finder.php

@@ -7,6 +7,7 @@
 use ArrayIterator;
 use ArrayLookup\Assert\Filter;
 use ArrayObject;
+use SplFixedArray;
 use Traversable;
 use Webmozart\Assert\Assert;
 
@@ -51,6 +52,10 @@ private static function resolveArrayFromTraversable(Traversable $traversable): a
             return $traversable->getArrayCopy();
         }
 
+        if ($traversable instanceof SplFixedArray) {
+            return $traversable->toArray();
+        }
+
         return iterator_to_array($traversable);
     }
 

tests/FinderTest.php

@@ -14,6 +14,7 @@
 use Iterator;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
+use SplFixedArray;
 use stdClass;
 
 use function current;
@@ -248,6 +249,16 @@ public static function lastReturnKeyDataProvider(): Iterator
             static fn(string $datum, int $key): bool => str_contains($datum, 'test') && $key === 1,
             null,
         ];
+        yield [
+            SplFixedArray::fromArray([6, 7, 8, 9]),
+            static fn($datum): bool => $datum > 5,
+            3,
+        ];
+        yield [
+            SplFixedArray::fromArray([6, 7, 8, 9]),
+            static fn($datum): bool => $datum < 5,
+            null,
+        ];
     }
 
     /**