enable phpunitCodeQuality prepared set

Author: samsonasik

rector.php

@@ -13,7 +13,8 @@
         deadCode: true,
         naming: true,
         privatization: true,
-        typeDeclarations: true
+        typeDeclarations: true,
+        phpunitCodeQuality: true
     )
     ->withComposerBased(phpunit: true)
     ->withSkip([

tests/AtLeastTest.php

@@ -5,6 +5,7 @@
 namespace ArrayLookup\Tests;
 
 use ArrayLookup\AtLeast;
+use Iterator;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 
@@ -19,29 +20,27 @@ public function testOnce(array $data, callable $filter, bool $expected): void
         );
     }
 
-    public static function onceDataProvider(): array
+    public static function onceDataProvider(): Iterator
     {
-        return [
-            [
-                [1, 2, 3],
-                static fn($datum): bool => $datum === 1,
-                true,
-            ],
-            [
-                [1, 2, 3],
-                static fn($datum): bool => $datum === 4,
-                false,
-            ],
-            [
-                ['abc', 'def', 'some test'],
-                static fn(string $datum, int $key): bool => $datum === 'def' && $key === 1,
-                true,
-            ],
-            [
-                ['abc', 'def', 'some test'],
-                static fn(string $datum, int $key): bool => $datum === 'def' && $key === 2,
-                false,
-            ],
+        yield [
+            [1, 2, 3],
+            static fn($datum): bool => $datum === 1,
+            true,
+        ];
+        yield [
+            [1, 2, 3],
+            static fn($datum): bool => $datum === 4,
+            false,
+        ];
+        yield [
+            ['abc', 'def', 'some test'],
+            static fn(string $datum, int $key): bool => $datum === 'def' && $key === 1,
+            true,
+        ];
+        yield [
+            ['abc', 'def', 'some test'],
+            static fn(string $datum, int $key): bool => $datum === 'def' && $key === 2,
+            false,
         ];
     }
 
@@ -55,29 +54,27 @@ public function testTwice(array $data, callable $filter, bool $expected): void
     }
 
     // phpcs:disable
-    public static function twiceDataProvider(): array
+    public static function twiceDataProvider(): Iterator
     {
-        return [
-            [
-                [1, "1", 2],
-                static fn($datum): bool => $datum == 1,
-                true,
-            ],
-            [
-                [1, "1", 3],
-                static fn($datum): bool => $datum === 1,
-                false,
-            ],
-            [
-                ['abc', 'def', 'some test'],
-                static fn(string $datum, int $key): bool => $datum !== 'abc' && $key > 0,
-                true
-            ],
-            [
-                ['abc', 'def', 'some test'],
-                static fn(string $datum, int $key): bool => $datum !== 'abc' && $key > 1,
-                false
-            ],
+        yield [
+            [1, "1", 2],
+            static fn($datum): bool => $datum == 1,
+            true,
+        ];
+        yield [
+            [1, "1", 3],
+            static fn($datum): bool => $datum === 1,
+            false,
+        ];
+        yield [
+            ['abc', 'def', 'some test'],
+            static fn(string $datum, int $key): bool => $datum !== 'abc' && $key > 0,
+            true
+        ];
+        yield [
+            ['abc', 'def', 'some test'],
+            static fn(string $datum, int $key): bool => $datum !== 'abc' && $key > 1,
+            false
         ];
     }
 
@@ -91,29 +88,27 @@ public function testTimes(array $data, callable $filter, bool $expected): void
         );
     }
 
-    public static function timesDataProvider(): array
+    public static function timesDataProvider(): Iterator
     {
-        return [
-            [
-                [0, false, null],
-                static fn($datum): bool => ! $datum,
-                true,
-            ],
-            [
-                [1, false, null],
-                static fn($datum): bool => ! $datum,
-                false,
-            ],
-            [
-                ['abc', 'def', 'some test', 'another test'],
-                static fn(string $datum, int $key): bool => $datum !== 'abc' && $key > 0,
-                true,
-            ],
-            [
-                ['abc', 'def', 'some test', 'another test'],
-                static fn(string $datum, int $key): bool => $datum !== 'abc' && $key > 1,
-                false,
-            ],
+        yield [
+            [0, false, null],
+            static fn($datum): bool => ! $datum,
+            true,
+        ];
+        yield [
+            [1, false, null],
+            static fn($datum): bool => ! $datum,
+            false,
+        ];
+        yield [
+            ['abc', 'def', 'some test', 'another test'],
+            static fn(string $datum, int $key): bool => $datum !== 'abc' && $key > 0,
+            true,
+        ];
+        yield [
+            ['abc', 'def', 'some test', 'another test'],
+            static fn(string $datum, int $key): bool => $datum !== 'abc' && $key > 1,
+            false,
         ];
     }
 }