update rector, move assign outside asset

Author: samsonasik

composer.json

@@ -74,7 +74,7 @@
         "phpstan/phpstan": "^1.0",
         "phpstan/phpstan-webmozart-assert": "^1.0",
         "pimple/pimple": "^3.2",
-        "rector/rector": "0.12.7",
+        "rector/rector": "0.12.8",
         "symfony/dependency-injection": "^5.0"
     },
     "suggest": {

spec/Integration/IntegrationViaErrorPreviewControllerForIdempotentSpec.php

@@ -30,7 +30,7 @@
 
     });
 
-    given('tableGateway', function () {
+    given('tableGateway', function (): TableGateway {
 
         $serviceManager = $this->application->getServiceManager();
         $db             = $serviceManager->get(AdapterInterface::class);

spec/Middleware/MezzioSpec.php

@@ -30,7 +30,7 @@
         'methods' => '__construct'
     ]));
 
-    given('renderer', function () {
+    given('renderer', function (): LaminasViewRenderer {
 
         $renderer = new PhpRenderer();
         $resolver = new AggregateResolver();
@@ -176,7 +176,7 @@
 
     ]);
 
-    given('dbWriter', function () {
+    given('dbWriter', function (): Db {
         $dbAdapter = new Adapter([
             'username' => 'root',
             'password' => '',

src/HeroTrait.php

@@ -36,7 +36,9 @@ public function phpError(...$args): void
     {
         if ($this instanceof Mvc) {
             Assert::count($args, 1);
-            Assert::isInstanceOf($this->mvcEvent = $args[0], MvcEvent::class);
+            Assert::isInstanceOf($args[0], MvcEvent::class);
+
+            $this->mvcEvent = $args[0];
         }
 
         if (! $this->errorHeroModuleConfig['display-settings']['display_errors']) {