no ned Zend\Http\Header\Cookie instance creation when request->getCookie() not instance of Cookie, which is false, set cookie_data to [] directly

Author: samsonasik

spec/Integration/IntegrationViaErrorPreviewControllerForHasCookieSpec.php

@@ -0,0 +1,88 @@
+<?php
+
+namespace ErrorHeroModule\Spec;
+
+use ErrorHeroModule;
+use ErrorHeroModule\Controller\ErrorPreviewController;
+use Zend\Console\Console;
+use Zend\Db\Adapter\Adapter;
+use Zend\Db\ResultSet\ResultSet;
+use Zend\Db\TableGateway\TableGateway;
+use Zend\Http\Header\Cookie;
+use Zend\Mvc\Application;
+
+describe('Integration via ErrorPreviewController for has cookie', function () {
+
+    given('application', function () {
+
+        Console::overrideIsConsole(false);
+
+        $application = Application::init([
+            'modules' => [
+                'Zend\Router',
+                'Zend\Db',
+                'ErrorHeroModule',
+            ],
+            'module_listener_options' => [
+                'config_glob_paths' => [
+                    realpath(__DIR__).'/../Fixture/config/autoload/error-hero-module.local.php',
+                    realpath(__DIR__).'/../Fixture/config/module.local.php',
+                ],
+            ],
+        ]);
+
+        $events         = $application->getEventManager();
+        $serviceManager = $application->getServiceManager();
+
+        $db  = $serviceManager->get(Adapter::class);
+        $tableGateway = new TableGateway('log', $db, null, new ResultSet());
+        $tableGateway->delete([]);
+
+        $application->getRequest()->setCookies(['foo' => 'value']);
+
+        return $application;
+
+    });
+
+    describe('/error-preview', function() {
+
+        it('show error page', function() {
+
+            $request     = $this->application->getRequest();
+            $request->setMethod('GET');
+            $request->setUri('http://example.com/error-preview');
+            $request->setRequestUri('/error-preview');
+
+            ob_start();
+            $this->application->run();
+            $content = ob_get_clean();
+
+            expect($content)->toContain('<title>Error');
+            expect($content)->toContain('<p>We have encountered a problem and we can not fulfill your request');
+            expect($this->application->getResponse()->getStatusCode())->toBe(500);
+
+        });
+
+    });
+
+    describe('/error-preview/error', function() {
+
+        it('show error page', function() {
+
+            $request     = $this->application->getRequest();
+            $request->setMethod('GET');
+            $request->setUri('http://example.com/error-preview/error');
+            $request->setRequestUri('/error-preview/error');
+
+            ob_start();
+            $this->application->run();
+            $content = ob_get_clean();
+
+            expect($content)->toContain('<title>Error');
+            expect($content)->toContain('<p>We have encountered a problem and we can not fulfill your request');
+            expect($this->application->getResponse()->getStatusCode())->toBe(500);
+
+        });
+    });
+
+});

src/Handler/Logging.php

@@ -116,13 +116,12 @@ private function getRequestData(RequestInterface $request) : array
         $files_data     = $request->getFiles()->toArray();
         $cookie         = $request->getCookie();
 
-        if ($cookie === false) {
-            $cookie = new Cookie([]);
+        if ($cookie instanceof Cookie) {
+            $cookie_data = $cookie->getArrayCopy();
+        } else {
+            $cookie_data = [];
         }
 
-        Assertion::isInstanceOf($cookie, Cookie::class);
-        $cookie_data = $cookie->getArrayCopy();
-
         return [
             'request_method' => $request_method,
             'query_data'     => $query_data,