Skip to content

Commit 55da943

Browse files
committed
using uri->toString() to get complete url
1 parent 29f313b commit 55da943

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

spec/Handler/LoggingSpec.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
beforeAll(function () {
2121
$this->logger = Double::instance(['extends' => Logger::class]);
22-
$this->request = Double::instance(['extends' => Request::class, 'methods' => '__construct']);
22+
$this->request = new Request();
2323
$this->errorHeroModuleLocalConfig = [
2424
'enable' => true,
2525
'display-settings' => [

src/Handler/Logging.php

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -156,25 +156,19 @@ private function collectErrorExceptionExtraData(array $collectedExceptionData, R
156156
{
157157
if ($request instanceof ConsoleRequest) {
158158
$serverUrl = \php_uname('n');
159-
$requestUri = ':' . \basename((string) \getcwd())
159+
$url = $serverUrl . ':' . \basename((string) \getcwd())
160160
. ' ' . \get_current_user()
161161
. '$ ' . \PHP_BINARY . ' ' . $request->getScriptName() . ' ' . $request->toString();
162162
} else {
163163
Assert::isInstanceOf($request, HttpRequest::class);
164164
$uri = $request->getUri();
165165
$serverUrl = $uri->getScheme() . '://' . $uri->getHost();
166-
$port = $uri->getPort();
167-
168-
if (! in_array($port, [80, 443], true)) {
169-
$serverUrl .= ':' . $port;
170-
}
171-
172-
$requestUri = $request->getRequestUri();
166+
$url = $uri->toString();
173167
}
174168

175169
return [
176170
'server_url' => $serverUrl,
177-
'url' => $serverUrl . $requestUri,
171+
'url' => $url,
178172
'file' => $collectedExceptionData['errorFile'],
179173
'line' => $collectedExceptionData['errorLine'],
180174
'error_type' => $collectedExceptionData['errorType'],

0 commit comments

Comments
 (0)