Skip to content

Commit beee247

Browse files
committed
use "listeners" key in module config instead of call in onBootstrap()
1 parent 3258e7b commit beee247

File tree

3 files changed

+4
-37
lines changed

3 files changed

+4
-37
lines changed

config/module.config.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@
4343
],
4444
],
4545

46+
'listeners' => [
47+
Listener\Mvc::class,
48+
],
49+
4650
'view_manager' => [
4751
'template_map' => [
4852
'error-hero-module/error-default' => __DIR__.'/../view/error-hero-module/error-default.phtml',

spec/ModuleSpec.php

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,12 @@
55
use Doctrine\DBAL\Connection;
66
use Doctrine\DBAL\Driver\PDOMySql\Driver;
77
use Doctrine\ORM\EntityManager;
8-
use ErrorHeroModule\Listener\Mvc;
98
use ErrorHeroModule\Module;
109
use Kahlan\Plugin\Double;
1110
use Zend\EventManager\EventManagerInterface;
1211
use Zend\ModuleManager\Listener\ConfigListener;
1312
use Zend\ModuleManager\ModuleEvent;
1413
use Zend\ModuleManager\ModuleManager;
15-
use Zend\Mvc\Application;
16-
use Zend\Mvc\MvcEvent;
1714
use Zend\ServiceManager\ServiceLocatorInterface;
1815

1916
describe('Module', function () {
@@ -161,27 +158,4 @@
161158

162159
});
163160

164-
describe('->onBootstrap()', function () {
165-
166-
it('pull Mvc Listener and use it to attach with EventManager', function () {
167-
168-
$application = Double::instance(['extends' => Application::class, 'methods' => '__construct']);
169-
$mvcListener = Double::instance(['extends' => Mvc::class, 'methods' => '__construct']);
170-
$serviceManager = Double::instance(['implements' => ServiceLocatorInterface::class]);
171-
$eventManager = Double::instance(['implements' => EventManagerInterface::class]);
172-
$mvcEvent = Double::instance(['extends' => MvcEvent::class]);
173-
174-
expect($mvcListener)->toReceive('attach')->with($eventManager);
175-
176-
allow($application)->toReceive('getServiceManager')->andReturn($serviceManager);
177-
allow($application)->toReceive('getEventManager')->andReturn($eventManager);
178-
allow($serviceManager)->toReceive('get')->with(Mvc::class)->andReturn($mvcListener);
179-
allow($mvcEvent)->toReceive('getApplication')->andReturn($application);
180-
181-
$this->module->onBootstrap($mvcEvent);
182-
183-
});
184-
185-
});
186-
187161
});

src/Module.php

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use Doctrine\ORM\EntityManager;
66
use Zend\ModuleManager\ModuleEvent;
77
use Zend\ModuleManager\ModuleManager;
8-
use Zend\Mvc\MvcEvent;
98

109
class Module
1110
{
@@ -64,16 +63,6 @@ public function convertDoctrineToZendDbConfig(ModuleEvent $event)
6463
$services->setAllowOverride($allowOverride);
6564
}
6665

67-
public function onBootstrap(MvcEvent $e)
68-
{
69-
$app = $e->getApplication();
70-
$services = $app->getServiceManager();
71-
$eventManager = $app->getEventManager();
72-
73-
$mvcListenerAggregate = $services->get(Listener\Mvc::class);
74-
$mvcListenerAggregate->attach($eventManager);
75-
}
76-
7766
public function getConfig()
7867
{
7968
return include __DIR__.'/../config/module.config.php';

0 commit comments

Comments
 (0)