apply code quality rector set

Author: samsonasik

rector.php

@@ -2,12 +2,16 @@
 
 declare(strict_types=1);
 
+use Rector\CodeQuality\Rector\Array_\CallableThisArrayToAnonymousFunctionRector;
+use Rector\CodeQuality\Rector\If_\ExplicitBoolCompareRector;
+use Rector\CodingStyle\Rector\ClassMethod\UnSpreadOperatorRector;
 use Rector\Core\Configuration\Option;
 use Rector\Core\ValueObject\PhpVersion;
 use Rector\Set\ValueObject\SetList;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
 return static function (ContainerConfigurator $containerConfigurator): void {
+    $containerConfigurator->import(SetList::CODE_QUALITY);
     $containerConfigurator->import(SetList::CODE_QUALITY_STRICT);
     $containerConfigurator->import(SetList::CODING_STYLE);
     $containerConfigurator->import(SetList::ORDER);
@@ -24,4 +28,10 @@
 
     $parameters->set(Option::AUTO_IMPORT_NAMES, true);
     $parameters->set(Option::PHP_VERSION_FEATURES, PhpVersion::PHP_80);
+
+    $parameters->set(Option::SKIP, [
+        CallableThisArrayToAnonymousFunctionRector::class,
+        ExplicitBoolCompareRector::class,
+        UnSpreadOperatorRector::class,
+    ]);
 };

spec/Integration/IntegrationViaErrorPreviewControllerForCannotConnecttoDBSpec.php

@@ -12,7 +12,7 @@
 
         Console::overrideIsConsole(false);
 
-        $application = Application::init([
+        return Application::init([
             'modules' => [
                 'Laminas\Router',
                 'Laminas\Db',
@@ -26,8 +26,6 @@
             ],
         ]);
 
-        return $application;
-
     });
 
     describe('/error-preview', function() {

spec/Integration/IntegrationViaErrorPreviewControllerForIdempotentSpec.php

@@ -15,7 +15,7 @@
 
         Console::overrideIsConsole(false);
 
-        $application = Application::init([
+        return Application::init([
             'modules' => [
                 'Laminas\Router',
                 'Laminas\Db',
@@ -29,8 +29,6 @@
             ],
         ]);
 
-        return $application;
-
     });
 
     given('tableGateway', function () {

spec/Integration/IntegrationViaErrorPreviewControllerForXmlHttpRequestSpec.php

@@ -14,7 +14,7 @@
 
         Console::overrideIsConsole(false);
 
-        $application = Application::init([
+        return Application::init([
             'modules' => [
                 'Laminas\Router',
                 'Laminas\Db',
@@ -28,8 +28,6 @@
             ],
         ]);
 
-        return $application;
-
     });
 
     describe('/error-preview', function() {

spec/Integration/IntegrationViaErrorPreviewControllerForXmlHttpRequestWithNonJsonMessageSpec.php

@@ -14,7 +14,7 @@
 
         Console::overrideIsConsole(false);
 
-        $application = Application::init([
+        return Application::init([
             'modules' => [
                 'Laminas\Router',
                 'Laminas\Db',
@@ -28,8 +28,6 @@
             ],
         ]);
 
-        return $application;
-
     });
 
     describe('/error-preview', function() {

src/HeroTrait.php

@@ -12,7 +12,6 @@
 
 use function error_get_last;
 use function error_reporting;
-use function func_get_args;
 use function ini_set;
 use function is_array;
 use function ob_end_flush;
@@ -31,10 +30,13 @@ trait HeroTrait
     /** @var string */
     private $result = '';
 
-    public function phpError(): void
+    /**
+     * @param mixed $args
+     */
+    public function phpError(...$args): void
     {
         if ($this instanceof Mvc) {
-            Assert::count($args = func_get_args(), 1);
+            Assert::count($args, 1);
             Assert::isInstanceOf($this->mvcEvent = $args[0], MvcEvent::class);
         }
 

src/Middleware/Mezzio.php

@@ -97,7 +97,7 @@ private function showDefaultView(): Response|HtmlResponse
             && $request->getHeaderLine('X-Requested-With') === 'XmlHttpRequest';
 
         if (
-            $isXmlHttpRequest === true &&
+            $isXmlHttpRequest &&
             isset($this->errorHeroModuleConfig['display-settings']['ajax']['message'])
         ) {
             return $this->responseByConfigMessage('ajax');