Skip to content

Commit ed2d26b

Browse files
committed
drop support for "elie29/zend-phpdi-config":"<4.0"
1 parent 349eb7e commit ed2d26b

File tree

3 files changed

+11
-23
lines changed

3 files changed

+11
-23
lines changed

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@
5353
},
5454
"conflict": {
5555
"doctrine/doctrine-orm-module": "<2.1",
56-
"elie29/zend-phpdi-config":"<3.0.8",
56+
"elie29/zend-phpdi-config":"<4.0",
5757
"zendframework/zend-expressive": "<3.0 >=4.0",
5858
"zendframework/zend-mvc": "<3.0 >=4.0",
5959
"zendframework/zend-servicemanager": "<3.3"
6060
},
6161
"require-dev": {
6262
"aura/di": "^3.4",
6363
"doctrine/doctrine-orm-module": "^2.1",
64-
"elie29/zend-phpdi-config":"^3.0.9|^4.0",
64+
"elie29/zend-phpdi-config":"^4.0",
6565
"kahlan/kahlan": "^4.1.1",
6666
"northwoods/container": "^3.0",
6767
"php-coveralls/php-coveralls": "^2.0",

spec/Middleware/ExpressiveFactorySpec.php

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
use Doctrine\DBAL\Connection;
1010
use Doctrine\DBAL\Driver\PDOMySql\Driver;
1111
use Doctrine\ORM\EntityManager;
12-
use Elie\PHPDI\Config\ContainerWrapper as EliePHPDIv4ContainerWrapper;
12+
use Elie\PHPDI\Config\ContainerWrapper as PHPDIContainerWrapper;
1313
use ErrorHeroModule\Handler\Logging;
1414
use ErrorHeroModule\Middleware\Expressive;
1515
use ErrorHeroModule\Middleware\ExpressiveFactory;
@@ -20,7 +20,6 @@
2020
use Pimple\Psr11\Container as Psr11PimpleContainer;
2121
use RuntimeException;
2222
use Symfony\Component\DependencyInjection\ContainerBuilder as SymfonyContainerBuilder;
23-
use Zend\DI\Config\ContainerWrapper as EliePHPDIv3ContainerWrapper;
2423
use Zend\Expressive\Template\TemplateRendererInterface;
2524
use Zend\ServiceManager\ServiceManager;
2625

@@ -31,20 +30,13 @@
3130
});
3231

3332
given('mapCreateContainers', function () {
34-
$map = [
33+
return [
3534
AuraContainer::class => (new AuraContainerBuilder())->newInstance(),
3635
SymfonyContainerBuilder::class => new SymfonyContainerBuilder(),
3736
AurynInjectorContainer::class => new AurynInjectorContainer(new AurynInjector()),
3837
Psr11PimpleContainer::class => new Psr11PimpleContainer(new PimpleContainer()),
38+
PHPDIContainerWrapper::class => new PHPDIContainerWrapper(),
3939
];
40-
41-
$elie29zendphpdiconfigVersion = str_replace('v', '', \PackageVersions\Versions::getVersion("elie29/zend-phpdi-config"));
42-
$phpDI = [
43-
$elie29zendphpdiconfigVersion >= 4 ? EliePHPDIv4ContainerWrapper::class : EliePHPDIv3ContainerWrapper::class
44-
=> $elie29zendphpdiconfigVersion >= 4 ? new EliePHPDIv4ContainerWrapper() : new EliePHPDIv3ContainerWrapper()
45-
];
46-
47-
return $phpDI + $map;
4840
});
4941

5042
given('config', function () {

src/Middleware/ExpressiveFactory.php

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
use ArrayObject;
88
use Aura\Di\Container as AuraContainer;
99
use Doctrine\ORM\EntityManager;
10-
use Elie\PHPDI\Config\ContainerWrapper as EliePHPDIv4ContainerWrapper;
10+
use Elie\PHPDI\Config\ContainerWrapper as PHPDIContainerWrapper;
1111
use ErrorHeroModule\Handler\Logging;
1212
use ErrorHeroModule\Transformer\AuraService;
1313
use ErrorHeroModule\Transformer\AurynService;
@@ -21,21 +21,17 @@
2121
use RuntimeException;
2222
use Symfony\Component\DependencyInjection\ContainerBuilder as SymfonyContainerBuilder;
2323
use Webmozart\Assert\Assert;
24-
use Zend\DI\Config\ContainerWrapper as EliePHPDIv3ContainerWrapper;
2524
use Zend\Expressive\Template\TemplateRendererInterface;
2625
use Zend\ServiceManager\ServiceManager;
2726

2827
class ExpressiveFactory
2928
{
3029
private const CONTAINERS_TRANSFORM = [
31-
SymfonyContainerBuilder::class => SymfonyService::class,
32-
AuraContainer::class => AuraService::class,
33-
AurynInjectorContainer::class => AurynService::class,
34-
Psr11PimpleContainer::class => PimpleService::class,
35-
// elie29/zend-phpdi-config ^v3.0.9
36-
EliePHPDIv3ContainerWrapper::class => PHPDIService::class,
37-
// elie29/zend-phpdi-config ^v4.0.0
38-
EliePHPDIv4ContainerWrapper::class => PHPDIService::class,
30+
SymfonyContainerBuilder::class => SymfonyService::class,
31+
AuraContainer::class => AuraService::class,
32+
AurynInjectorContainer::class => AurynService::class,
33+
Psr11PimpleContainer::class => PimpleService::class,
34+
PHPDIContainerWrapper::class => PHPDIService::class,
3935
];
4036

4137
private function createMiddlewareInstance(ContainerInterface $container, array $configuration) : Expressive

0 commit comments

Comments
 (0)