Skip to content

Commit ef2c52b

Browse files
committed
__invoke signature fix of $next and various type hint added
1 parent 297c9aa commit ef2c52b

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

spec/Middleware/ForceHttpsSpec.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
use ForceHttpsModule\Middleware\ForceHttps;
66
use Kahlan\Plugin\Double;
77
use Zend\Console\Console;
8+
use Psr\Http\Message\UriInterface;
9+
use Psr\Http\Message\ResponseInterface;
810
use Psr\Http\Message\ServerRequestInterface;
9-
use Zend\Diactoros\Response;
1011
use Zend\Diactoros\Uri;
1112
use Zend\Expressive\Router\RouterInterface;
1213
use Zend\Expressive\Router\RouteResult;
@@ -16,19 +17,19 @@
1617
describe('->invoke()', function () {
1718

1819
given('response', function () {
19-
return Double::instance(['extends' => Response::class]);
20+
return Double::instance(['implements' => ResponseInterface::class]);
2021
});
2122

2223
given('request', function () {
23-
return Double::instance(['implements' => ServerRequestInterface::class]);
24+
return Double::instance(['implements' => ServerRequestInterface::class]);
2425
});
2526

2627
given('uri', function () {
27-
return Double::instance(['extends' => Uri::class]);
28+
return Double::instance(['implements' => UriInterface::class]);
2829
});
2930

3031
given('router', function () {
31-
return Double::instance(['implements' => RouterInterface::class]);
32+
return Double::instance(['implements' => RouterInterface::class]);
3233
});
3334

3435
it('not redirect on console', function () {

src/Middleware/ForceHttps.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
namespace ForceHttpsModule\Middleware;
44

55
use ForceHttpsModule\HttpsTrait;
6+
use Psr\Http\Message\ResponseInterface;
7+
use Psr\Http\Message\ServerRequestInterface;
68
use Zend\Console\Console;
79
use Zend\Expressive\Router\RouterInterface;
810
use Zend\Expressive\Router\RouteResult;
@@ -30,12 +32,11 @@ public function __construct(array $config, RouterInterface $router)
3032
/**
3133
* Set The HTTP Strict Transport Security.
3234
*
33-
* @param string $uriScheme
34-
* @param RouteResult $match
35-
*
36-
* @param $response
35+
* @param string $uriScheme
36+
* @param RouteResult $match
37+
* @param ResponseInterface $response
3738
*/
38-
private function setHttpStrictTransportSecurity($uriScheme, RouteResult $match, $response)
39+
private function setHttpStrictTransportSecurity($uriScheme, RouteResult $match, ResponseInterface $response)
3940
{
4041
if (
4142
$this->isSchemeHttps($uriScheme) &&
@@ -57,7 +58,7 @@ private function setHttpStrictTransportSecurity($uriScheme, RouteResult $match,
5758
return $response;
5859
}
5960

60-
public function __invoke($request, $response, callable $next = null)
61+
public function __invoke(ServerRequestInterface $request, ResponseInterface $response, callable $next)
6162
{
6263
$match = $this->router->match($request);
6364
if (Console::isConsole() || ! $this->config['enable'] || $match->isFailure()) {

0 commit comments

Comments
 (0)