Merge pull request #10 from samsonasik/handle-no-letter

[validator] Validate no letter

Author: samsonasik

README.md

@@ -42,6 +42,7 @@ Validation checks
 
 - Allowed characters: letters, hyphens, apostrophe, spaces, full stops.
 - Not allowed:
+   - no letter, eg: ` - `
    - include number
    - special characters
    - single `.` character

spec/Validator/NamingSpec.php

@@ -13,6 +13,12 @@
         it('returns false for incorrect naming', function (): void {
 
             $namings = [
+                // no letter
+                ' ',
+                '   ',
+                ' - ',
+                '- -',
+
                 // include special character(s)
                 '~~',
                 'abdul%',
@@ -38,6 +44,9 @@
                 "''",
                 '...',
                 'Foo.....',
+
+                // invalid characters
+                '<>'
             ];
 
             foreach ($namings as $naming) {
@@ -57,6 +66,7 @@
                 "D'Lilah",
                 'Veli-Matti',
                 'Setälä',
+                'X Æ A-Xii',
             ];
 
             foreach ($namings as $naming) {

src/Validator/Naming.php

@@ -16,6 +16,11 @@
 
 final class Naming extends AbstractValidator
 {
+    /**
+     * @var string
+     */
+    private const MUST_CONTAIN_LETTER = 'MUST_CONTAIN_LETTER';
+
     /**
      * @var string
      */
@@ -58,6 +63,7 @@ final class Naming extends AbstractValidator
 
     /** @var array<string, string> */
     protected array $messageTemplates = [
+        self::MUST_CONTAIN_LETTER    => 'Name must contain at least one letter',
         self::SPECIAL_OR_NUMBER      => 'Names can contain only letters, hyphens, apostrophe, spaces & full stops',
         self::SINGLE_DOT             => 'Single "." character is not allowed',
         self::SINGLE_HYPHEN          => 'Single "-" character is not allowed',
@@ -81,7 +87,7 @@ public function isValid(mixed $value): bool
             return false;
         }
 
-        $length = mb_strlen($value);
+        $length = mb_strlen($value, 'UTF-8');
         if ($length === 1) {
             $messageTemplates = [
                 '.' => self::SINGLE_DOT,
@@ -116,6 +122,11 @@ public function isValid(mixed $value): bool
             return false;
         }
 
+        if (! preg_match('#\p{L}#u', $value)) {
+            $this->error(self::MUST_CONTAIN_LETTER);
+            return false;
+        }
+
         return true;
     }
 }