Some code simplifications with the return statement

Author: dilyanpalauzov

vdirsyncer/cli/config.py

@@ -263,12 +263,9 @@ def _process_conflict_resolution_param(
     ):
         if conflict_resolution in (None, "a wins", "b wins"):
             return conflict_resolution
-        elif (
-            isinstance(conflict_resolution, list)
-            and len(conflict_resolution) > 1
-            and conflict_resolution[0] == "command"
-        ):
-
+        if isinstance(conflict_resolution, list) and \
+                len(conflict_resolution) > 1 and \
+                conflict_resolution[0] == "command":
             def resolve(a, b):
                 a_name = self.config_a["instance_name"]
                 b_name = self.config_b["instance_name"]
@@ -277,8 +274,7 @@ def resolve(a, b):
                 return _resolve_conflict_via_command(a, b, command, a_name, b_name)
 
             return resolve
-        else:
-            raise ValueError("Invalid value for `conflict_resolution`.")
+        raise ValueError("Invalid value for `conflict_resolution`.")
 
     # The following parameters are lazily evaluated because evaluating
     # self.config_a would expand all `x.fetch` parameters. This is costly and

vdirsyncer/cli/discover.py

@@ -67,16 +67,15 @@ async def collections_for_pair(
                     rv["collections"], pair.config_a, pair.config_b
                 )
             )
-        elif rv:
+        if rv:
             raise exceptions.UserError(
                 "Detected change in config file, "
                 f"please run `vdirsyncer discover {pair.name}`."
             )
-        else:
-            raise exceptions.UserError(
-                f"Please run `vdirsyncer discover {pair.name}` "
-                " before synchronization."
-            )
+        raise exceptions.UserError(
+            f"Please run `vdirsyncer discover {pair.name}` "
+            " before synchronization."
+        )
 
     logger.info(f"Discovering collections for pair {pair.name}")
 

vdirsyncer/cli/utils.py

@@ -299,8 +299,7 @@ async def storage_instance_from_config(
                 create=False,
                 connector=connector,
             )
-        else:
-            raise
+        raise
     except Exception:
         return handle_storage_init_error(cls, new_config)
 

vdirsyncer/http.py

@@ -40,11 +40,11 @@ def prepare_auth(auth, username, password):
     if username and password:
         if auth == "basic" or auth is None:
             return aiohttp.BasicAuth(username, password)
-        elif auth == "digest":
+        if auth == "digest":
             from requests.auth import HTTPDigestAuth
 
             return HTTPDigestAuth(username, password)
-        elif auth == "guess":
+        if auth == "guess":
             try:
                 from requests_toolbelt.auth.guess import GuessAuth
             except ImportError:
@@ -62,8 +62,6 @@ def prepare_auth(auth, username, password):
             f"You need to specify username and password for {auth} authentication."
         )
 
-    return None
-
 
 def prepare_verify(verify, verify_fingerprint):
     if isinstance(verify, str):

vdirsyncer/storage/dav.py

@@ -98,7 +98,7 @@ def _parse_xml(content):
 
 def _merge_xml(items):
     if not items:
-        return None
+        return
     rv = items[0]
     for item in items[1:]:
         rv.extend(item.iter())
@@ -114,9 +114,7 @@ def _fuzzy_matches_mimetype(strict, weak):
         return True
 
     mediatype, subtype = strict.split("/")
-    if subtype in weak:
-        return True
-    return False
+    return subtype in weak
 
 
 class Discover:
@@ -237,7 +235,7 @@ def _check_collection_resource_type(self, response):
             return True
 
         props = _merge_xml(response.findall("{DAV:}propstat/{DAV:}prop"))
-        if props is None or not len(props):
+        if props is None or not props:
             dav_logger.debug("Skipping, missing <prop>: %s", response)
             return False
         if props.find("{DAV:}resourcetype/" + self._resourcetype) is None:
@@ -628,11 +626,10 @@ def _parse_prop_responses(self, root, handled_hrefs=None):
                 continue
 
             props = response.findall("{DAV:}propstat/{DAV:}prop")
-            if props is None or not len(props):
+            if props is None or not props:
                 dav_logger.debug(f"Skipping {href!r}, properties are missing.")
                 continue
-            else:
-                props = _merge_xml(props)
+            props = _merge_xml(props)
 
             if props.find("{DAV:}resourcetype/{DAV:}collection") is not None:
                 dav_logger.debug(f"Skipping {href!r}, is collection.")
@@ -713,7 +710,6 @@ async def get_meta(self, key) -> str | None:
             text = normalize_meta_value(getattr(prop, "text", None))
             if text:
                 return text
-        return None
 
     async def set_meta(self, key, value):
         try:

vdirsyncer/storage/filesystem.py

@@ -205,9 +205,7 @@ async def get_meta(self, key):
             with open(fpath, "rb") as f:
                 return normalize_meta_value(f.read().decode(self.encoding))
         except OSError as e:
-            if e.errno == errno.ENOENT:
-                return None
-            else:
+            if e.errno != errno.ENOENT:
                 raise
 
     async def set_meta(self, key, value):

vdirsyncer/sync/status.py

@@ -256,12 +256,12 @@ def _get_impl(self, ident, side, table):
             (ident,),
         ).fetchone()
         if res is None:
-            return None
+            return
 
         if res["hash"] is None:  # FIXME: Implement as constraint in db
             assert res["href"] is None
             assert res["etag"] is None
-            return None
+            return
 
         res = dict(res)
         return ItemMetadata(**res)

vdirsyncer/utils.py

@@ -22,8 +22,7 @@
 def expand_path(p: str) -> str:
     """Expand $HOME in a path and normalise slashes."""
     p = os.path.expanduser(p)
-    p = os.path.normpath(p)
-    return p
+    return os.path.normpath(p)
 
 
 def split_dict(d: dict, f: Callable):
@@ -174,8 +173,7 @@ def generate_href(ident=None, safe=SAFE_UID_CHARS):
     """
     if not ident or not href_safe(ident, safe):
         return str(uuid.uuid4())
-    else:
-        return ident
+    return ident
 
 
 def synchronized(lock=None):

vdirsyncer/vobject.py

@@ -231,8 +231,7 @@ def _get_item_type(components, wrappers):
 
     if not i:
         return None, None
-    else:
-        raise ValueError("Not sure how to join components.")
+    raise ValueError("Not sure how to join components.")
 
 
 class _Component:
@@ -303,10 +302,9 @@ def parse(cls, lines, multiple=False):
 
         if multiple:
             return rv
-        elif len(rv) != 1:
+        if len(rv) != 1:
             raise ValueError(f"Found {len(rv)} components, expected one.")
-        else:
-            return rv[0]
+        return rv[0]
 
     def dump_lines(self):
         yield f"BEGIN:{self.name}"
@@ -323,8 +321,7 @@ def __delitem__(self, key):
             for line in lineiter:
                 if line.startswith(prefix):
                     break
-                else:
-                    new_lines.append(line)
+                new_lines.append(line)
             else:
                 break
 
@@ -345,12 +342,10 @@ def __setitem__(self, key, val):
     def __contains__(self, obj):
         if isinstance(obj, type(self)):
             return obj not in self.subcomponents and not any(
-                obj in x for x in self.subcomponents
-            )
-        elif isinstance(obj, str):
+                 obj in x for x in self.subcomponents)
+        if isinstance(obj, str):
             return self.get(obj, None) is not None
-        else:
-            raise ValueError(obj)
+        raise ValueError(obj)
 
     def __getitem__(self, key):
         prefix_without_params = f"{key}:"
@@ -360,7 +355,7 @@ def __getitem__(self, key):
             if line.startswith(prefix_without_params):
                 rv = line[len(prefix_without_params) :]
                 break
-            elif line.startswith(prefix_with_params):
+            if line.startswith(prefix_with_params):
                 rv = line[len(prefix_with_params) :].split(":", 1)[-1]
                 break
         else: