Fix racket#1352: Add validation in has-struct-property->sc

When looking up a struct property type, consolidated error handling into
a single match expression that properly handles missing types and non-
struct-property types instead of causing internal errors.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Closes racket#1352

Author: samth

typed-racket-lib/typed-racket/private/type-contract.rkt

@@ -1389,7 +1389,19 @@
 (define (has-struct-property->sc orig-id)
   ;; we can't call syntax-local-value/immediate in has-struct-property case in parse-type
   (define-values (a prop-name) (syntax-local-value/immediate orig-id (λ () (values #t orig-id))))
-  (match-define (Struct-Property: _ pred?) (lookup-id-type/lexical prop-name))
+  (define pred?
+    (match (lookup-id-type/lexical prop-name)
+      [(Struct-Property: _ (? values p)) p]
+      [(Struct-Property: _ #f)
+       (tc-error/fields "struct property has no predicate"
+                        #:stx orig-id
+                        "property" (syntax-e orig-id))]
+      [#f (tc-error/fields "could not find type for struct property"
+                           #:stx orig-id
+                           "property" (syntax-e orig-id))]
+      [other (tc-error/fields "expected a Struct-Property type"
+                              #:stx orig-id
+                              "given type" other)]))
   ;; if original-name is only set when the type is added via require/typed
 
   ;; the original-name of `prop-name` is its original referece in the unexpanded program.

typed-racket-test/fail/gh-issue-1352.rkt

@@ -0,0 +1,10 @@
+#;
+(exn-pred #rx"struct property has no predicate")
+#lang typed/racket
+
+;; Issue #1352: syntax-property: contract violation with Has-Struct-Property
+;; Bug in type-contract.rkt has-struct-property->sc function
+
+(require/typed racket/stream
+  [prop:stream (Struct-Property Any)]
+  [stream->list (-> (Has-Struct-Property prop:stream) (List Any))])