Make the header compatibility check more strict. Fixes #1591

Author: pd3

test/test.pl

@@ -1566,11 +1566,18 @@ sub test_naive_concat
     my $seed = srand();
     print STDERR "Random seed for test_naive_concat: $seed\n";
 
+    my @hdr  = ();
+    my $nhdr = 1 + int(rand($args{max_hdr_lines}));
+    for (my $i=0; $i<$nhdr; $i++)
+    {
+        my $x = rand;
+        push @hdr, "##INFO=<ID=XX$i,Number=1,Type=Integer,Description=\"Test Tag $x\">\n";
+    }
+
     my @files = ();
     my $exp   = '';
     for (my $n=0; $n<$args{nfiles}; $n++)
     {
-        my $nhdr = 1 + int(rand($args{max_hdr_lines}));
         my $nbdy = int(rand($args{max_body_lines}));
         my $file = "$$opts{tmp}/$args{name}.$n";
         push @files,$file;
@@ -1579,11 +1586,7 @@ sub test_naive_concat
         print $fh "##fileformat=VCFv4.0\n";
         print $fh "##INFO=<ID=DP,Number=1,Type=Integer,Description=\"Read Depth\">\n";
         print $fh "##contig=<ID=1,length=62435964>\n";
-        for (my $i=0; $i<$nhdr; $i++)
-        {
-            my $x = rand;
-            print $fh "##INFO=<ID=XX$i,Number=1,Type=Integer,Description=\"Test Tag $x\">\n";
-        }
+        print $fh join('',@hdr);
         print $fh join("\t",'#CHROM','POS','ID','REF','ALT','QUAL','FILTER','INFO')."\n";
 
         # let one of the files have no body

vcfconcat.c

@@ -780,11 +780,6 @@ static void naive_concat_check_headers(args_t *args)
         // if BCF, check if tag IDs are consistent in the dictionary of strings
         if ( type.compression!=bgzf )
             error("The --naive option works only for compressed BCFs or VCFs, sorry :-/\n");
-        if ( type.format==vcf )
-        {
-            bcf_hdr_destroy(hdr);
-            continue;
-        }
 
         _check_hrecs(hdr0,hdr,args->fnames[0],args->fnames[i]);
         _check_hrecs(hdr,hdr0,args->fnames[i],args->fnames[0]);