Skip to content

Commit 353fa94

Browse files
committed
[SQUASH ME]
Edits from review
1 parent 9f91aa5 commit 353fa94

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

cram/cram_decode.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2390,8 +2390,8 @@ int cram_decode_slice(cram_fd *fd, cram_container *c, cram_slice *s,
23902390

23912391
if ((fd->required_fields & SAM_SEQ) &&
23922392
s->ref == NULL && s->hdr->ref_seq_id >= 0 && !c->comp_hdr->no_ref) {
2393-
hts_log_error("Unable to fetch reference #%d:%"PRId64"-%"PRId64"\n",
2394-
ref_id, s->hdr->ref_seq_start,
2393+
hts_log_error("Unable to fetch reference %s:%"PRId64"-%"PRId64,
2394+
fd->refs->ref_id[ref_id]->name, s->hdr->ref_seq_start,
23952395
s->hdr->ref_seq_start + s->hdr->ref_seq_span-1);
23962396
return -1;
23972397
}

cram/cram_io.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3440,7 +3440,9 @@ char *cram_get_ref(cram_fd *fd, int id, hts_pos_t start, hts_pos_t end) {
34403440
hts_log_warning("Reference file given, but ref '%s' not present",
34413441
r->name);
34423442
if (cram_populate_ref(fd, id, r) == -1) {
3443-
hts_log_warning("Failed to populate reference for id %d", id);
3443+
hts_log_warning("Failed to populate reference \"%s\"",
3444+
r->name);
3445+
hts_log_warning("See https://www.htslib.org/doc/reference_seqs.html for further suggestions");
34443446
pthread_mutex_unlock(&fd->refs->lock);
34453447
pthread_mutex_unlock(&fd->ref_lock);
34463448
return NULL;

0 commit comments

Comments
 (0)