refactor(shared table): use within within(baseElement) when available

GuillaumeKESTEMAN · GuillaumeKESTEMAN · commit c28646bab122 · 2023-12-18T16:30:35.000+01:00
diff --git a/src/shared/components/Table/Body/__tests__/Body.test.tsx b/src/shared/components/Table/Body/__tests__/Body.test.tsx
@@ -24,7 +24,7 @@ describe('Body', () => {
 
   it('Render <Body/> with 1 item', () => {
     const { baseElement } = renderWithContainer(<Body items={items} />, container);
-    expect(screen.getAllByRole('row').length).toBe(1);
+    expect(within(baseElement).getAllByRole('row').length).toBe(1);
     within(baseElement).getByText(items[0].cols.firstname.label);
     within(baseElement).getByText(items[0].cols.lastname.label);
     within(baseElement).getByText(items[0].cols.birthdate.label);
diff --git a/src/shared/components/Table/Header/__tests__/Header.test.tsx b/src/shared/components/Table/Header/__tests__/Header.test.tsx
@@ -1,5 +1,5 @@
 import { renderWithContainer } from 'shared/testsUtils';
-import { screen } from 'shared/testsUtils/customRender';
+import { screen, within } from 'shared/testsUtils/customRender';
 import Header from '../Header';
 
 const defaultProps = {
@@ -30,7 +30,7 @@ describe('Header', () => {
     ${undefined}   | ${sortingMock} | ${undefined}
     ${headersMock} | ${sortingMock} | ${(<th>child header</th>)}
   `('Should render Header when headers: $headers, sorting: $sorting', ({ headers, sorting, children }) => {
-    renderWithContainer(
+    const { baseElement } = renderWithContainer(
       <Header {...defaultProps} headers={headers} sorting={sorting}>
         {children}
       </Header>,
@@ -47,7 +47,7 @@ describe('Header', () => {
       columnHeaderNumber += 1;
     }
 
-    expect(screen.queryAllByRole('columnheader').length).toBe(columnHeaderNumber);
+    expect(within(baseElement).queryAllByRole('columnheader').length).toBe(columnHeaderNumber);
     if (headers?.length > 0) {
       screen.getByText('label');
     }
