Fix error when calculating SVG highlight rectangles

samuelbradshaw · samuelbradshaw · commit 15e3d7fd799d · 2025-02-23T01:06:48.000-07:00
diff --git a/highlight-helper.js b/highlight-helper.js
@@ -1112,7 +1112,7 @@ function Highlighter(options = hhDefaultOptions) {
     const ancestorElementsInRange = [];
     for (const paragraph of paragraphs) {
       let element = paragraph;
-      while (element !== range.commonAncestorContainer) {
+      while (range.commonAncestorContainer.contains(element)) {
         if (!ancestorElementsInRange.includes(element)) ancestorElementsInRange.push(element);
         element = element.parentElement;
       }

Original file line number	Diff line number	Diff line change
`@@ -1112,7 +1112,7 @@ function Highlighter(options = hhDefaultOptions) {`
`1112`	`1112`	`const ancestorElementsInRange = [];`
`1113`	`1113`	`for (const paragraph of paragraphs) {`
`1114`	`1114`	`let element = paragraph;`
`1115`		`- while (element !== range.commonAncestorContainer) {`
	`1115`	`+ while (range.commonAncestorContainer.contains(element)) {`
`1116`	`1116`	`if (!ancestorElementsInRange.includes(element)) ancestorElementsInRange.push(element);`
`1117`	`1117`	`element = element.parentElement;`
`1118`	`1118`	`}`